Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1105273002: Fix disassembly page after profile page (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

- Fully load both Dart and Stub code kinds - Ouptut "_optimized" field for fake code objects. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45433

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M runtime/observatory/lib/src/elements/code_view.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 8 months ago (2015-04-27 21:50:14 UTC) #2
srdjan
lgtm
5 years, 8 months ago (2015-04-27 21:51:33 UTC) #3
Cutch
5 years, 8 months ago (2015-04-27 22:00:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698