"Load image" context menu item to reload a LoFi image.

content/renderer/context_menu_params_builder.cc

Index: content/renderer/context_menu_params_builder.cc
diff --git a/content/renderer/context_menu_params_builder.cc b/content/renderer/context_menu_params_builder.cc
index 63dcd4d1e7b6b3c5b903b9dac8906f4e88882da2..7872a639c4a1cfc6223682d14d9af8dc57269627 100644
--- a/content/renderer/context_menu_params_builder.cc
+++ b/content/renderer/context_menu_params_builder.cc
@@ -5,8 +5,10 @@
 #include "content/renderer/context_menu_params_builder.h"
 
 #include "base/logging.h"
+#include "content/child/weburlresponse_extradata_impl.h"
 #include "content/common/ssl_status_serialization.h"
 #include "content/public/common/context_menu_params.h"
+#include "content/public/renderer/content_renderer_client.h"
 #include "content/renderer/dom_utils.h"
 #include "content/renderer/history_serialization.h"
 #include "content/renderer/menu_item_builder.h"
@@ -43,6 +45,11 @@ ContextMenuParams ContextMenuParamsBuilder::Build(
   params.referrer_policy = data.referrerPolicy;
   params.suggested_filename = data.suggestedFilename;
 
+  if (!data.imageResponse.isNull()) {
+    GetContentClient()->renderer()->AddContextMenuProperties(

[Charlie Reis, 2015/05/15 22:37:46]

Seems strange that this is only called in the imageResponse case, since the
AddContextMenuProperties name is more general.  Should we change the name, or
should it be called in other cases as well?

[megjablon, 2015/05/15 22:52:22]

Getting a ResourceResponse for more or all cases from blink would be require a
lot of changes. We are able to grab it for our specific image case through the
HTMLImageElement's ImageResource. Until there is a need to have the
ResourceResponse for other cases, I don't think we should add extra
implementation for it. I named AddContextMenuProperties as generally as possible
since in the future it could be used in other locations. Maybe changing it to
AddContextMenuResourceResponseProperties makes better sense?

[Charlie Reis, 2015/05/15 22:59:09]

Yes, that's certainly fine.
The name can be changed if it needs to be more general in the future, but we
shouldn't imply that it does more currently.
That implies that it's for all resource responses, but it's only called for
images.  My concern is that other people will see the name of the method and
think it's more general than it is.

AddImageContextMenuProperties seems the most accurate name to me, unless I'm
missing something.

[megjablon, 2015/05/15 23:16:05]

SGTM

+        data.imageResponse, &params.properties);
+  }
+
   for (size_t i = 0; i < data.dictionarySuggestions.size(); ++i)
     params.dictionary_suggestions.push_back(data.dictionarySuggestions[i]);