Issue 1105203002: Revert of Stop closing batch prematurely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1105203002: Revert of Stop closing batch prematurely (Closed)

Created:
5 years, 8 months ago by joshualitt

Modified:
5 years, 8 months ago

Reviewers:
bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@atdfopt3

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Stop closing batch prematurely (patchset #4 id:60001 of https://codereview.chromium.org/1092403002/) Reason for revert: really does break windows bots Original issue's description: > In this CL we stop closing batches prematurely, and only close immediately before a flush. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/db3ce12c810ead7b76faa784e7293197aca0d9f1 > > Committed: https://skia.googlesource.com/skia/+/9e830ead85e544924344b01436c44cfb09fcf177 TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/385e26ef36af65bfe97567657d5b9a3207627a07

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -51 lines)			Patch
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrTargetCommands.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/gpu/GrTargetCommands.cpp	View	12 chunks	+16 lines, -40 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105203002/1

5 years, 8 months ago (2015-04-27 18:42:25 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 18:42:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/385e26ef36af65bfe97567657d5b9a3207627a07