Issue 11052023: Update indexeddb tests to work with both methods of upgrading a database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11052023: Update indexeddb tests to work with both methods of upgrading a database. (Closed)

Created:
8 years, 2 months ago by sra1

Modified:
8 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update indexeddb tests to work with both methods of upgrading a database. The 'unpgradeNeeded' method is standard and supported by FireFox and Chrome tip. The 'setVersions' method will be needed until Chrome Stable is Chrome 24. The tests work locally for FireFox 15 provided they are run from a http:// URL. Running from a file:// URL disables IndexedDB for security reasons. Committed: https://code.google.com/p/dart/source/detail?r=13271

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -119 lines)			Patch
M	tests/html/html.status	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	tests/html/indexeddb_1_test.dart	View	1	9 chunks	+59 lines, -26 lines	0 comments	Download
M	tests/html/indexeddb_2_test.dart	View		6 chunks	+32 lines, -20 lines	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	1	4 chunks	+59 lines, -32 lines	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View		3 chunks	+61 lines, -36 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 2 months ago (2012-10-04 15:42:10 UTC) #2

lgtm

https://codereview.chromium.org/11052023/diff/2001/tests/html/indexeddb_1_tes...
File tests/html/indexeddb_1_test.dart (right):

https://codereview.chromium.org/11052023/diff/2001/tests/html/indexeddb_1_tes...
tests/html/indexeddb_1_test.dart:69: if (request is IDBOpenDBRequest) {
Can you add some comments on which browsers take which paths through this?

Expand Messages | Collapse Messages