Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11052011: Fix some warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 1a24e639124b794e02b1573a88d08edfb17b4844..db2c5005505abe97003b41478f0f41ecaa7b6768 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -76,7 +76,8 @@ class SsaCodeGeneratorTask extends CompilerTask {
Map<Element, String> parameterNames = getParameterNames(work);
// Use [work.element] to ensure that the parameter element come from
// the declaration.
- work.element.computeSignature(compiler).forEachParameter((element) {
+ FunctionElement function = work.element;
+ function.computeSignature(compiler).forEachParameter((element) {
compiler.enqueuer.codegen.addToWorkList(element);
});
List<js.Parameter> parameters = <js.Parameter>[];
@@ -178,7 +179,7 @@ class SsaCodeGeneratorTask extends CompilerTask {
typedef void ElementAction(Element element);
-class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
+abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
/**
* Returned by [expressionType] to tell how code can be generated for
* a subgraph.
@@ -1816,6 +1817,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
">=" : "<"
};
HRelational relational = input;
+
visitInvokeBinary(input,
inverseOperator[relational.operation.name.stringValue]);
} else {
@@ -2448,7 +2450,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
helper = castNames[helper.stringValue];
}
}
- Element helperElement = compiler.findHelper(helper);
+ FunctionElement helperElement = compiler.findHelper(helper);
world.registerStaticUse(helperElement);
List<js.Expression> arguments = <js.Expression>[];
use(node.checkedInput);
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698