Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: vm/debugger_api_impl.cc

Issue 11052006: 1. Create a port when a debugger object is created for an isolate, use this (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/debugger.cc ('k') | vm/debugger_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/debugger_api_impl.cc
===================================================================
--- vm/debugger_api_impl.cc (revision 13206)
+++ vm/debugger_api_impl.cc (working copy)
@@ -100,8 +100,7 @@
}
-DART_EXPORT void Dart_SetBreakpointHandler(
- Dart_BreakpointHandler bp_handler) {
+DART_EXPORT void Dart_SetBreakpointHandler(Dart_BreakpointHandler bp_handler) {
BreakpointHandler* handler =
reinterpret_cast<BreakpointHandler*>(bp_handler);
Debugger::SetBreakpointHandler(handler);
@@ -134,15 +133,15 @@
(*exc_thrown_handler)(exception, trace);
} else if (event->type == Debugger::kIsolateCreated) {
if (isolate_event_handler != NULL) {
- (*isolate_event_handler)(Api::CastIsolate(event->isolate), kCreated);
+ (*isolate_event_handler)(event->isolate_id, kCreated);
}
} else if (event->type == Debugger::kIsolateInterrupted) {
if (isolate_event_handler != NULL) {
- (*isolate_event_handler)(Api::CastIsolate(event->isolate), kInterrupted);
+ (*isolate_event_handler)(event->isolate_id, kInterrupted);
}
} else if (event->type == Debugger::kIsolateShutdown) {
if (isolate_event_handler != NULL) {
- (*isolate_event_handler)(Api::CastIsolate(event->isolate), kShutdown);
+ (*isolate_event_handler)(event->isolate_id, kShutdown);
}
} else {
UNIMPLEMENTED();
@@ -710,4 +709,9 @@
}
+DART_EXPORT Dart_Isolate Dart_GetIsolate(Dart_IsolateId isolate_id) {
+ Isolate* isolate = PortMap::GetIsolate(isolate_id);
+ return Api::CastIsolate(isolate);
+}
+
} // namespace dart
« no previous file with comments | « vm/debugger.cc ('k') | vm/debugger_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698