Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/browser/apps/drive/drive_app_converter.cc

Issue 1105193002: Fix potential UAF in DriveAppConverter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/drive/drive_app_converter.cc
diff --git a/chrome/browser/apps/drive/drive_app_converter.cc b/chrome/browser/apps/drive/drive_app_converter.cc
index 581b67c5ae68049fc552446e516157f3cb18ca87..94552b669c0a30b2db648f61b05afb5c7db14553 100644
--- a/chrome/browser/apps/drive/drive_app_converter.cc
+++ b/chrome/browser/apps/drive/drive_app_converter.cc
@@ -7,6 +7,7 @@
#include <algorithm>
#include <set>
+#include "base/callback_helpers.h"
#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/strings/utf_string_conversions.h"
@@ -198,6 +199,6 @@ void DriveAppConverter::OnFinishCrxInstall(const std::string& extension_id,
is_new_install_ = success && crx_installer_->current_version().empty();
PostInstallCleanUp();
- finished_callback_.Run(this, success);
+ base::ResetAndReturn(&finished_callback_).Run(this, success);
// |finished_callback_| could delete this.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698