Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1105163004: Revert of [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by xhwang
Modified:
5 years, 7 months ago
Reviewers:
anujsharma
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (patchset #3 id:40001 of https://codereview.chromium.org/1108773002/) Reason for revert: see https://code.google.com/p/chromium/issues/detail?id=481632 Original issue's description: > Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in src/media. > > MessageLoopProxy is deprecated. > This basically does a search and replace: > > MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). > > BUG=391045 > > Committed: https://crrev.com/902e992a9b6447028bf8d4f3540892c425984b8f > Cr-Commit-Position: refs/heads/master@{#327075} TBR=anujk.sharma@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=391045 Committed: https://crrev.com/84a3918452ae67b24bc60acdf7abd7b226879a5e Cr-Commit-Position: refs/heads/master@{#327142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -68 lines) Patch
M media/audio/audio_input_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/audio/audio_manager_base.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/android/media_player_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/bind_to_current_loop.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/fake_text_track_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/base/serial_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/cdm/default_cdm_factory.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/filters/clockless_video_frame_scheduler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/filters/default_media_permission.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/filters/fake_demuxer_stream.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/video/capture/linux/video_capture_device_chromeos.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac_unittest.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M media/video/capture/mac/video_capture_device_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xhwang
Created Revert of [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle
5 years, 7 months ago (2015-04-27 21:39:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105163004/1
5 years, 7 months ago (2015-04-27 21:40:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 21:42:22 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:43:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84a3918452ae67b24bc60acdf7abd7b226879a5e
Cr-Commit-Position: refs/heads/master@{#327142}

Powered by Google App Engine
This is Rietveld 408576698