Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/browser/ui/cocoa/share_menu_controller_unittest.mm

Issue 1105143005: Issue 465302:System wide share options on Mac Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests, honored Cocoa memory management issues Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h"
6
7 #include "base/mac/scoped_nsobject.h"
8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
10 #include "base/threading/thread_restrictions.h"
11 #include "chrome/browser/browser_process.h"
12 #include "chrome/browser/prefs/pref_service_syncable.h"
13 #include "chrome/browser/profiles/profile_manager.h"
14 #include "chrome/browser/ui/browser_list.h"
15 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
16 #include "chrome/browser/ui/cocoa/run_loop_testing.h"
17 #include "chrome/common/pref_names.h"
18 #include "chrome/grit/generated_resources.h"
19 #include "chrome/test/base/test_browser_window.h"
20 #include "chrome/test/base/testing_profile.h"
21 #include "chrome/test/base/ui_test_utils.h"
22 #include "chrome/browser/ui/tabs/tab_strip_model.h"
23 #include "testing/gtest_mac.h"
24 #include "ui/base/l10n/l10n_util_mac.h"
25
26 class ShareMenuControllerTest : public CocoaProfileTest {
27 public:
28 ShareMenuControllerTest() {
29 menu_.reset([NSApp mainMenu]);
30 controller_.reset(
31 [[ShareMenuController alloc] initWithMainMenu:menu_]);
32 }
33
34 void SetUp() override {
35 CocoaProfileTest::SetUp();
36
37 // Spin the runloop so |-initializeMenu| gets called.
38 chrome::testing::NSRunLoopRunAllPending();
39 }
40
41 ShareMenuController* controller() { return controller_.get(); }
42
43 NSMenu* mainmenu() { return menu_.get(); }
44
45 private:
46 base::scoped_nsobject<NSMenu> menu_;
47 base::scoped_nsobject<ShareMenuController> controller_;
48 };
49
50 TEST_F(ShareMenuControllerTest, InitializeMenu) {
51 [controller() initShareMenuItem];
52 NSMenuItem* shareMenuItem = [controller() shareSubMenuItem];
53 EXPECT_NSEQ(@"Share", [shareMenuItem title]);
54 }
55
56 TEST_F(ShareMenuControllerTest, BuildShareMenuItems) {
57 [controller() initShareMenuItem];
58 TestingProfileManager* manager = testing_profile_manager();
59 TestingProfile* profile = manager->CreateTestingProfile("TestProfile");
60 Browser::CreateParams profile_params(profile, chrome::GetActiveDesktop());
61 scoped_ptr<Browser> browser(
62 chrome::CreateBrowserWithTestWindowForParams(&profile_params));
63 TabStripModel* tabStrip = browser.get()->tab_strip_model();
64 content::WebContents* wc = content::WebContents::Create(
65 content::WebContents::CreateParams(profile));
66 tabStrip->AppendWebContents(wc, true);
67 BrowserList::SetLastActive(browser.get());
68 NSMenu* shareMenu = [controller() shareSubMenu];
69 ASSERT_EQ(5, [shareMenu numberOfItems]);
70 for (NSMenuItem* item in [shareMenu itemArray]) {
71 EXPECT_TRUE([item action] == @selector(systemShareService:));
72 }
73
74 // close the tab
Avi (use Gerrit) 2015/05/15 16:13:09 Complete sentences here and below. Capital letter,
75 tabStrip->CloseWebContentsAt(tabStrip->active_index(), 0);
76 // destroy the browser
77 browser.reset();
78 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698