Issue 465302:System wide share options on Mac

chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h

+// Copyright 2015 The Chromium Authors. All rights reserved.

[Avi (use Gerrit), 2015/05/15 16:13:08]

Why are you putting this into renderer_context_menu?

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER
+#define CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER
+
+#import <Cocoa/Cocoa.h>
+
+#import "base/mac/scoped_nsobject.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/ui/browser.h"
+namespace ShareMenuControllerInternal {

[Avi (use Gerrit), 2015/05/15 16:13:08]

Blank line before this one.

+    class Observer;

[Avi (use Gerrit), 2015/05/15 16:13:08]

Bad spacing; no indenting inside namespaces.

+}
+
+@interface ShareMenuController : NSObject {
+ @private
+    __weak NSMenu* mainMenu_;
+    scoped_ptr<ShareMenuControllerInternal::Observer> observer_;
+    base::scoped_nsobject<NSMutableArray> shareItems_;
+    NSMenuItem* shareMenuItem_;
+    base::scoped_nsobject<NSMenu> shareSubMenu_;
+    NSMenuItem* fileMenuItem_;
+    BOOL menuItemsLoaded_;

[Avi (use Gerrit), 2015/05/15 16:13:08]

Indent 2.

+}
+
+- (id)initWithMainMenu:(NSMenu* )menu;

[Avi (use Gerrit), 2015/05/15 16:13:08]

No space after *

+- (BOOL)menuItemsLoaded;

[Avi (use Gerrit), 2015/05/15 16:13:08]

comment functions

+
+@end
+
+@interface ShareMenuController(PrivateShareMenuControllerTesting)
+- (void)initShareMenuItem;
+- (NSMenu*)shareSubMenu;
+- (NSMenuItem*)shareSubMenuItem;
+@end
+
+#endif // CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER