Issue 465302:System wide share options on Mac

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 48 matching lines @@
 #import "chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.h"
 #include "chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"
 #import "chrome/browser/ui/cocoa/confirm_quit.h"
 #import "chrome/browser/ui/cocoa/confirm_quit_panel_controller.h"
 #import "chrome/browser/ui/cocoa/encoding_menu_controller_delegate_mac.h"
 #include "chrome/browser/ui/cocoa/handoff_active_url_observer_bridge.h"
 #import "chrome/browser/ui/cocoa/history_menu_bridge.h"
 #include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h"
 #import "chrome/browser/ui/cocoa/profiles/profile_menu_controller.h"
+#import "chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/user_manager.h"
 #include "chrome/browser/web_applications/web_app_mac.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/cloud_print/cloud_print_class_mac.h"
@@ skipping 125 matching lines @@
     return false;
   return cache.ProfileIsSigninRequiredAtIndex(profile_index);
 }
 
 }  // namespace
 
 @interface AppController () <HandoffActiveURLObserverBridgeDelegate>
 
 - (void)initMenuState;
 - (void)initProfileMenu;
+- (void)initShareMenu;
 - (void)updateConfirmToQuitPrefMenuItem:(NSMenuItem*)item;
 - (void)updateDisplayMessageCenterPrefMenuItem:(NSMenuItem*)item;
 - (void)registerServicesMenuTypesTo:(NSApplication*)app;
 - (void)getUrl:(NSAppleEventDescriptor*)event
      withReply:(NSAppleEventDescriptor*)reply;
 - (void)activeSpaceDidChange:(NSNotification*)inNotification;
 - (void)checkForAnyKeyWindows;
 - (BOOL)userWillWaitForInProgressDownloads:(int)downloadCount;
 - (BOOL)shouldQuitWithInProgressDownloads;
 - (void)executeApplication:(id)sender;
@@ skipping 157 matching lines @@
       addObserver:self
          selector:@selector(willPowerOff:)
              name:NSWorkspaceWillPowerOffNotification
            object:nil];
 
   // Set up the command updater for when there are no windows open
   [self initMenuState];
 
   // Initialize the Profile menu.
   [self initProfileMenu];
+
+  // Initialize the Share Menu. Limit execution of this method for OSX
+  // versions >= 10.9.
+#if defined(MAC_OS_X_VERSION_10_9) && \
+MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_9
+  [self initShareMenu];
+#endif

[Avi (use Gerrit), 2015/05/15 16:13:08]

No.

You're doing a compile-time check, and you need a run-time check.

Also, what happens before 10.9? We just leave a dead menu item?

+
 }
 
 - (void)unregisterEventHandlers {
   NSAppleEventManager* em = [NSAppleEventManager sharedAppleEventManager];
   [em removeEventHandlerForEventClass:kInternetEventClass
                            andEventID:kAEGetURL];
   [em removeEventHandlerForEventClass:cloud_print::kAECloudPrintClass
                            andEventID:cloud_print::kAECloudPrintClass];
   [em removeEventHandlerForEventClass:'WWW!'
                            andEventID:'OURL'];
@@ skipping 195 matching lines @@
   // window remain. It seems that the new key window for the app is not set
   // until after this notification is fired, so a check is performed after the
   // run loop is allowed to spin.
   [self performSelector:@selector(checkForAnyKeyWindows)
              withObject:nil
              afterDelay:0.0];
 }
 
 - (void)windowDidBecomeMain:(NSNotification*)notify {
   Browser* browser = chrome::FindBrowserWithWindow([notify object]);
-  if (browser)
-    [self windowChangedToProfile:browser->profile()->GetOriginalProfile()];
+    if (browser)
+      [self windowChangedToProfile:browser->profile()->GetOriginalProfile()];

[Avi (use Gerrit), 2015/05/15 16:13:08]

Please don't make random formatting changes.

 }
 
 - (void)windowDidResignMain:(NSNotification*)notify {
   if (chrome::GetTotalBrowserCount() == 0) {
     [self windowChangedToProfile:
         g_browser_process->profile_manager()->GetLastUsedProfile()];
   }
 }
 
 - (void)activeSpaceDidChange:(NSNotification*)notify {
@@ skipping 686 matching lines @@
     return;
   }
 
   // The controller will unhide the menu if necessary.
   [profileMenu setHidden:YES];
 
   profileMenuController_.reset(
       [[ProfileMenuController alloc] initWithMainMenuItem:profileMenu]);
 }
 
+- (void)initShareMenu {
+  NSMenu* mainMenu = [NSApp mainMenu];
+
+  shareMenuController_.reset(
+      [[ShareMenuController alloc] initWithMainMenu:mainMenu]);
+}
+
 // The Confirm to Quit preference is atypical in that the preference lives in
 // the app menu right above the Quit menu item. This method will refresh the
 // display of that item depending on the preference state.
 - (void)updateConfirmToQuitPrefMenuItem:(NSMenuItem*)item {
   // Format the string so that the correct key equivalent is displayed.
   NSString* acceleratorString = [ConfirmQuitPanelController keyCommandString];
   NSString* title = l10n_util::GetNSStringF(IDS_CONFIRM_TO_QUIT_OPTION,
       base::SysNSStringToUTF16(acceleratorString));
   [item setTitle:title];
 
@@ skipping 388 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac