Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: base/trace_event/malloc_dump_provider.cc

Issue 1105143003: [tracing] Simplify the MemoryAllocatorDump API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplif_2
Patch Set: Fix Win build Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/trace_event/malloc_dump_provider.h" 5 #include "base/trace_event/malloc_dump_provider.h"
6 6
7 #include <malloc.h> 7 #include <malloc.h>
8 8
9 #include "base/trace_event/process_memory_dump.h" 9 #include "base/trace_event/process_memory_dump.h"
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 MallocDumpProvider::~MallocDumpProvider() { 23 MallocDumpProvider::~MallocDumpProvider() {
24 } 24 }
25 25
26 // Called at trace dump point time. Creates a snapshot the memory counters for 26 // Called at trace dump point time. Creates a snapshot the memory counters for
27 // the current process. 27 // the current process.
28 bool MallocDumpProvider::OnMemoryDump(ProcessMemoryDump* pmd) { 28 bool MallocDumpProvider::OnMemoryDump(ProcessMemoryDump* pmd) {
29 struct mallinfo info = mallinfo(); 29 struct mallinfo info = mallinfo();
30 DCHECK_GE(info.arena + info.hblkhd, info.uordblks); 30 DCHECK_GE(info.arena + info.hblkhd, info.uordblks);
31 31
32 MemoryAllocatorDump* dump = 32 MemoryAllocatorDump* dump = pmd->CreateAllocatorDump("malloc");
33 pmd->CreateAllocatorDump("malloc", MemoryAllocatorDump::kRootHeap);
34 if (!dump) 33 if (!dump)
35 return false; 34 return false;
36 35
37 // When the system allocator is implemented by tcmalloc, the total physical 36 // When the system allocator is implemented by tcmalloc, the total physical
38 // size is given by |arena| and |hblkhd| is 0. In case of Android's jemalloc 37 // size is given by |arena| and |hblkhd| is 0. In case of Android's jemalloc
39 // |arena| is 0 and the outer pages size is reported by |hblkhd|. In case of 38 // |arena| is 0 and the outer pages size is reported by |hblkhd|. In case of
40 // dlmalloc the total is given by |arena| + |hblkhd|. 39 // dlmalloc the total is given by |arena| + |hblkhd|.
41 // For more details see link: http://goo.gl/fMR8lF. 40 // For more details see link: http://goo.gl/fMR8lF.
42 dump->set_physical_size_in_bytes(info.arena + info.hblkhd); 41 dump->AddScalar(MemoryAllocatorDump::kNameOuterSize,
43 42 MemoryAllocatorDump::kUnitsBytes, info.arena + info.hblkhd);
44 // mallinfo doesn't support any allocated object count.
45 dump->set_allocated_objects_count(0);
46 43
47 // Total allocated space is given by |uordblks|. 44 // Total allocated space is given by |uordblks|.
48 dump->set_allocated_objects_size_in_bytes(info.uordblks); 45 dump->AddScalar(MemoryAllocatorDump::kNameInnerSize,
46 MemoryAllocatorDump::kUnitsBytes, info.uordblks);
49 47
50 return true; 48 return true;
51 } 49 }
52 50
53 } // namespace trace_event 51 } // namespace trace_event
54 } // namespace base 52 } // namespace base
OLDNEW
« no previous file with comments | « base/trace_event/java_heap_dump_provider_android.cc ('k') | base/trace_event/memory_allocator_dump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698