Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/dom/scripts/systemnative.py

Issue 110513002: Change generator to pass in domData in calls to createWrapper. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemnative.py
===================================================================
--- tools/dom/scripts/systemnative.py (revision 30992)
+++ tools/dom/scripts/systemnative.py (working copy)
@@ -426,7 +426,7 @@
' DartDOMWrapper::lookupWrapper(domData, isNode, value);\n'
' if (result)\n'
' return Dart_HandleFromWeakPersistent(result);\n'
- ' return createWrapper(value);\n'
+ ' return createWrapper(domData, value);\n'
' }\n'
' static void returnToDart(Dart_NativeArguments args,\n'
' NativeType* value)\n'
@@ -439,7 +439,7 @@
' if (result)\n'
' Dart_SetWeakHandleReturnValue(args, result);\n'
' else\n'
- ' Dart_SetReturnValue(args, createWrapper(value));\n'
+ ' Dart_SetReturnValue(args, createWrapper(domData, value));\n'
' }\n'
' }\n',
)
@@ -449,12 +449,11 @@
'CPPPureInterface' in ext_attrs or
self._interface_type_info.custom_to_dart()):
to_dart_emitter.Emit(
- ' static Dart_Handle createWrapper(NativeType* value);\n')
+ ' static Dart_Handle createWrapper(DartDOMData* domData, NativeType* value);\n')
else:
to_dart_emitter.Emit(
- ' static Dart_Handle createWrapper(NativeType* value)\n'
+ ' static Dart_Handle createWrapper(DartDOMData* domData, NativeType* value)\n'
' {\n'
- ' DartDOMData* domData = DartDOMData::current();\n'
' return DartDOMWrapper::createWrapper<Dart$(INTERFACE)>(domData, value);\n'
' }\n',
INTERFACE=self._interface.id)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698