Issue 11051027: install script now knows how to kill MSBuild and devenv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11051027: install script now knows how to kill MSBuild and devenv (Closed)

Created:
8 years, 2 months ago by Sam Clegg

Modified:
8 years, 2 months ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

install script now knows how to kill MSBuild and devenv BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1427

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -17 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/InstallerResources/install.py	View		6 chunks	+54 lines, -17 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

binji

8 years, 2 months ago (2012-10-04 18:23:40 UTC) #2

lgtm, though it keeps making me think it will be nicer to have a real windows
installer for this stuff.

http://codereview.chromium.org/11051027/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

http://codereview.chromium.org/11051027/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:63: tasklist =
os.popen('tasklist.exe').readlines()
why not subprocess? I suppose if popen works, fine. (though the docs say it is
deprecated since 2.6)
But remove import above in that case.

http://codereview.chromium.org/11051027/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:182:
ppapi_answer = Ask("Set up configuration to enable Pepper development " \
nit: line continuations aren't necessary

Expand Messages | Collapse Messages