pkg/dartdoc/lib/src/dartdoc/utils.dart - Issue 11051004: Dartdoc method sorting says it's case insensitive, but isn't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dartdoc/lib/src/dartdoc/utils.dart

Issue 11051004: Dartdoc method sorting says it's case insensitive, but isn't (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/dartdoc/lib/src/dartdoc/utils.dart

===================================================================

--- pkg/dartdoc/lib/src/dartdoc/utils.dart (revision 13132)

+++ pkg/dartdoc/lib/src/dartdoc/utils.dart (working copy)

@@ -50,8 +50,8 @@

List<Mirror> orderByName(Collection<Mirror> list) {

final elements = new List<Mirror>.from(list);

elements.sort((a,b) {

- String aName = a.simpleName;

- String bName = b.simpleName;

+ String aName = a.simpleName.toLowerCase();

+ String bName = b.simpleName.toLowerCase();

bool doma = aName.startsWith(r"$dom");

bool domb = bName.startsWith(r"$dom");

return doma == domb ? aName.compareTo(bName) : doma ? 1 : -1;

« no previous file with comments | « no previous file | no next file » | no next file with comments »