Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 11051003: Implement Android WebView.clearCache (Closed)

Created:
8 years, 2 months ago by boliu
Modified:
8 years, 2 months ago
Reviewers:
joth, jam
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Implement part of Android WebView.clearCache For velocity, not refactoring BrowsingDataRemover code into content/. This method is similar to BrowsingDataRemover::REMOVE_CACHE mask. Still need to implement clearing http disk cache. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159827

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. Prepare for submitting this portion. #

Total comments: 1

Patch Set 3 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -1 line) Patch
M android_webview/android_webview.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/common/render_view_messages.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 chunks +12 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 2 chunks +18 lines, -0 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
A android_webview/renderer/aw_render_process_observer.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A android_webview/renderer/aw_render_process_observer.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M android_webview/renderer/aw_render_view_ext.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
boliu
Work in progress. #1 in downstream bug done. Still need to clear disk cache and ...
8 years, 2 months ago (2012-10-02 21:19:10 UTC) #1
joth
lg with changes you already mention. Seems OK to land this as first step and ...
8 years, 2 months ago (2012-10-02 21:36:38 UTC) #2
boliu
Prepare for submitting incomplete implementation. Added some TODOs. Left incomplete test there since it shows ...
8 years, 2 months ago (2012-10-02 22:06:59 UTC) #3
joth
lgtm https://codereview.chromium.org/11051003/diff/5001/android_webview/renderer/aw_render_process_observer.h File android_webview/renderer/aw_render_process_observer.h (right): https://codereview.chromium.org/11051003/diff/5001/android_webview/renderer/aw_render_process_observer.h#newcode14 android_webview/renderer/aw_render_process_observer.h:14: // An RenderProcessObserver implementation used for handling android_webview ...
8 years, 2 months ago (2012-10-02 23:01:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/11051003/11004
8 years, 2 months ago (2012-10-02 23:07:21 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 01:44:48 UTC) #6
Change committed as 159827

Powered by Google App Engine
This is Rietveld 408576698