Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1105063003: Only try to unregister prototype users that are prototypes themselves (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only try to unregister prototype users that are prototypes themselves Because only such maps would have been registered in the first place. This is a performance fix/followup to f6187fb3b52e518 / r28076. BUG=chromium:481785 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/6270b797bcd49362958e8c2d2661cab9dac35908 Cr-Commit-Position: refs/heads/master@{#28101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
PTAL.
5 years, 7 months ago (2015-04-28 10:37:14 UTC) #1
Yang
On 2015/04/28 10:37:14, Jakob wrote: > PTAL. lgtm.
5 years, 7 months ago (2015-04-28 10:37:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105063003/1
5 years, 7 months ago (2015-04-28 10:38:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 11:02:49 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 11:03:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6270b797bcd49362958e8c2d2661cab9dac35908
Cr-Commit-Position: refs/heads/master@{#28101}

Powered by Google App Engine
This is Rietveld 408576698