Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1105063002: Documents what ApplicationManager::Delegate do (Closed)

Created:
5 years, 8 months ago by qsr
Modified:
5 years, 7 months ago
Reviewers:
DaveMoore
CC:
mojo-reviews_chromium.org, ppi+watch_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Documents what ApplicationManager::Delegate do And renames one to better indicate what it is expected to do. This is a port of https://codereview.chromium.org/1052103005/. R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/605969e23d7ea113cc7c0a8a7e72f76217332450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M shell/application_manager/application_manager.h View 1 chunk +10 lines, -3 lines 0 comments Download
M shell/application_manager/application_manager.cc View 4 chunks +4 lines, -14 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M shell/context.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M shell/native_runner_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
5 years, 8 months ago (2015-04-27 11:25:30 UTC) #1
qsr
gentle ping?
5 years, 7 months ago (2015-04-30 08:02:34 UTC) #2
DaveMoore
lgtm
5 years, 7 months ago (2015-04-30 11:32:36 UTC) #3
qsr
5 years, 7 months ago (2015-04-30 11:51:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
605969e23d7ea113cc7c0a8a7e72f76217332450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698