Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1104973002: Fix //content/test:test_support under component builds. (Closed)

Created:
5 years, 8 months ago by Sam McNally
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //content/test:test_support under component builds. Previously, //content/test:test_support depended directly on *_sources targets. In component builds, this caused the browser_tests and content_browsertests binaries to include their own copies of content as well as depend on libcontent.so. This caused browser_tests and content_browsertests to crash on startup. This CL changes test_support to depend on the targets that forward to //content in component builds and introduces such targets for gpu and ppapi_plugin. The test_support changes also exposed underspecified dependencies in extensions/renderer/BUILD.gn and third_party/libjingle/BUILD.gn, and incorrect generated file dependencies in content/browser/devtools; the generated files depend on other non-generated files so have to be directly included in //content/browser. BUG=432959 Committed: https://crrev.com/d06e3fcfcc33e9e5a9f427e21a17054a981fc7b9 Cr-Commit-Position: refs/heads/master@{#327188}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M content/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 3 chunks +1 line, -7 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +16 lines, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +15 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sam McNally
5 years, 8 months ago (2015-04-27 09:20:26 UTC) #4
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-27 19:37:05 UTC) #5
Sam McNally
+brettw for OWNERS.
5 years, 8 months ago (2015-04-27 23:47:01 UTC) #7
brettw
Nice! LGTM
5 years, 8 months ago (2015-04-28 00:02:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104973002/60001
5 years, 8 months ago (2015-04-28 00:10:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 8 months ago (2015-04-28 00:15:05 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 00:16:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d06e3fcfcc33e9e5a9f427e21a17054a981fc7b9
Cr-Commit-Position: refs/heads/master@{#327188}

Powered by Google App Engine
This is Rietveld 408576698