Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 11049023: [dart2js] Report an error if throw is used outside of catch expression without an argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/resolver.dart ('k') | lib/compiler/implementation/warnings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index c3deabd100b724d52d9546d5d613a49114ed22b0..03109eaf8858d4b900a8216a9c460d719831d0de 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -3197,8 +3197,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
HInstruction exception = rethrowableException;
if (exception === null) {
exception = graph.addConstantNull(constantSystem);
- compiler.reportError(node,
- 'throw without expression outside catch block');
+ compiler.internalError(
+ 'rethrowableException should not be null', node: node);
}
close(new HThrow(exception, isRethrow: true));
} else {
« no previous file with comments | « lib/compiler/implementation/resolver.dart ('k') | lib/compiler/implementation/warnings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698