lib/compiler/implementation/ssa/builder.dart - Issue 11049023: [dart2js] Report an error if throw is used outside of catch expression without an argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 11049023: [dart2js] Report an error if throw is used outside of catch expression without an argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/builder.dart

diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart

index c3deabd100b724d52d9546d5d613a49114ed22b0..c895e244f727ecc967faef3298e07cc68c83daca 100644

--- a/lib/compiler/implementation/ssa/builder.dart

+++ b/lib/compiler/implementation/ssa/builder.dart

@@ -3197,8 +3197,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

HInstruction exception = rethrowableException;

if (exception === null) {

exception = graph.addConstantNull(constantSystem);

- compiler.reportError(node,

- 'throw without expression outside catch block');

+ compiler.reportError(node, MessageKind.THROW_WITHOUT_EXPRESSION);

ahe 2012/10/03 09:57:39 This would be an internal error now.

Roman 2012/10/03 10:07:34 Done. I also changed the wording to 'rethrowableEx

}

close(new HThrow(exception, isRethrow: true));

} else {

« no previous file with comments | « lib/compiler/implementation/resolver.dart ('k') | lib/compiler/implementation/warnings.dart » ('j') | lib/compiler/implementation/warnings.dart » ('J')