Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 1104883002: Ignore a11y failures in extension browser_tests that enter dev mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
index 8183dc84cac804e3b2b14191ee045603b73a5346..ada780243ecd89d88c4f542a809a5163cce9bd13 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
@@ -88,6 +88,7 @@ ExtensionSettingsWebUITest.prototype = {
/** @protected */
verifyDeveloperModeWorks: function() {
+ this.ignoreDevModeA11yFailures();
var extensionSettings = getRequiredElement('extension-settings');
assertFalse(extensionSettings.classList.contains('dev-mode'));
$('toggle-dev-on').click();
@@ -114,7 +115,25 @@ ExtensionSettingsWebUITest.prototype = {
this.verifyDeveloperModeWorks,
testDone];
this.nextStep();
- }
+ },
+
+ /**
+ * TODO(hcarmona): Remove this as part of fixing crbug.com/463245.
+ * Will ignore accessibility failures caused by the transition when developer
+ * mode is enabled.
Devlin 2015/04/27 15:49:24 nit: I'd comment on why we ignore it, and why it's
+ * @protected
+ */
+ ignoreDevModeA11yFailures: function() {
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'focusableElementNotVisibleAndNotAriaHidden',
+ '#load-unpacked');
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'focusableElementNotVisibleAndNotAriaHidden',
+ '#pack-extension');
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'focusableElementNotVisibleAndNotAriaHidden',
+ '#update-extensions-now');
+ },
};
// Verify that developer mode doesn't change behavior when the number of
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698