Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1104863003: Update {virtual,override} to follow C++11 style in src/pipe. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in src/pipe. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/pipe -iname "*.h" -or -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/d96fd0c073fa44a475363003c8f0d25a077edc6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/pipe/SkGPipeWrite.cpp View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
5 years, 8 months ago (2015-04-24 19:36:17 UTC) #1
mtklein
Ah, great! As you might have guessed, we fixed all the single-line virtual...override cases, but ...
5 years, 8 months ago (2015-04-24 19:44:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104863003/1
5 years, 8 months ago (2015-04-24 20:07:17 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 20:12:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d96fd0c073fa44a475363003c8f0d25a077edc6c

Powered by Google App Engine
This is Rietveld 408576698