Adds public API and loads Cast OSD plane implementation from shared lib

Adds public API and loads Cast OSD plane implementation from shared lib

BUG=

Committed: https://crrev.com/3da8f19ab50e6416f0691f34fe45b007dd886e59
Cr-Commit-Position: refs/heads/master@{#327306}

[halliwell, 2015-04-24 14:44:50]

halliwell@chromium.org changed reviewers:
+ byungchul@chromium.org, gunsch@chromium.org, lcwu@chromium.org

[gunsch, 2015-04-27 16:40:27]

lgtm with some minor comments

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:47: 'public/rect.h',
a nit: this adds a lot of small files, do they need to all be separate?
(particularly rect/size)

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
File chromecast/graphics/osd_plane_default.cc (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:35: Size size_;
nit: DISALLOW_COPY_AND_ASSIGN

[byungchul, 2015-04-27 16:55:03]

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
File chromecast/graphics/osd_plane_default.cc (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:20: void Blit(OsdSurface* src_surface,
// OsdSurface implementation:

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:43: OsdSurface* CreateSurface(const
Size& size) override {
// OsdPlane implementation:

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:52: }
remove {}

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:60: Size size_;
DISALLOW_...

https://codereview.chromium.org/1104853002/diff/1/chromecast/public/osd_plane...
File chromecast/public/osd_plane_shlib.h (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/public/osd_plane...
chromecast/public/osd_plane_shlib.h:22: }
// namespace chromecast and a blank line above here.

[halliwell, 2015-04-27 20:54:24]

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:47: 'public/rect.h',
On 2015/04/27 16:40:27, gunsch wrote:
> a nit: this adds a lot of small files, do they need to all be separate?
> (particularly rect/size)

Don't need to be, do we have a convention for grouping small types like this? 
types.h?  graphics_types.h?

[gunsch, 2015-04-27 21:13:53]

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:47: 'public/rect.h',
On 2015/04/27 20:54:24, halliwell wrote:
> On 2015/04/27 16:40:27, gunsch wrote:
> > a nit: this adds a lot of small files, do they need to all be separate?
> > (particularly rect/size)
> 
> Don't need to be, do we have a convention for grouping small types like this? 
> types.h?  graphics_types.h?

It looks like *_types.h has a lot of precedent in chromium.

[halliwell, 2015-04-27 21:30:42]

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:47: 'public/rect.h',
On 2015/04/27 21:13:53, gunsch wrote:
> On 2015/04/27 20:54:24, halliwell wrote:
> > On 2015/04/27 16:40:27, gunsch wrote:
> > > a nit: this adds a lot of small files, do they need to all be separate?
> > > (particularly rect/size)
> > 
> > Don't need to be, do we have a convention for grouping small types like
this? 
> > types.h?  graphics_types.h?
> 
> It looks like *_types.h has a lot of precedent in chromium.

Ok, moved to graphics_types.h

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
File chromecast/graphics/osd_plane_default.cc (right):

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:20: void Blit(OsdSurface* src_surface,
On 2015/04/27 16:55:03, byungchul wrote:
> // OsdSurface implementation:

Done.

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:35: Size size_;
On 2015/04/27 16:40:27, gunsch wrote:
> nit: DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:43: OsdSurface* CreateSurface(const
Size& size) override {
On 2015/04/27 16:55:03, byungchul wrote:
> // OsdPlane implementation:

Done.

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:52: }
On 2015/04/27 16:55:03, byungchul wrote:
> remove {}

Done.

https://codereview.chromium.org/1104853002/diff/1/chromecast/graphics/osd_pla...
chromecast/graphics/osd_plane_default.cc:60: Size size_;
On 2015/04/27 16:55:03, byungchul wrote:
> DISALLOW_...

Done.

[byungchul, 2015-04-27 21:42:14]

lgtm

nits only

https://codereview.chromium.org/1104853002/diff/20001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/chromecast.g...
chromecast/chromecast.gyp:48: 'public/size.h'
not updated.

https://codereview.chromium.org/1104853002/diff/20001/chromecast/graphics/osd...
File chromecast/graphics/osd_plane_default.cc (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/graphics/osd...
chromecast/graphics/osd_plane_default.cc:35: Size size_;
const

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/graph...
File chromecast/public/graphics_types.h (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/graph...
chromecast/public/graphics_types.h:13: : x(arg_x), y(arg_y), width(w), height(h)
{}
A blank line here

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/graph...
chromecast/public/graphics_types.h:21: Size(int w, int h) : width(w), height(h)
{}
ditto

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/osd_s...
File chromecast/public/osd_surface.h (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/osd_s...
chromecast/public/osd_surface.h:19: Point(int arg_x, int arg_y) : x(arg_x),
y(arg_y) {}
a blank line

[halliwell, 2015-04-27 22:17:33]

https://codereview.chromium.org/1104853002/diff/20001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/chromecast.g...
chromecast/chromecast.gyp:48: 'public/size.h'
On 2015/04/27 21:42:14, byungchul wrote:
> not updated.

Done.

https://codereview.chromium.org/1104853002/diff/20001/chromecast/graphics/osd...
File chromecast/graphics/osd_plane_default.cc (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/graphics/osd...
chromecast/graphics/osd_plane_default.cc:35: Size size_;
On 2015/04/27 21:42:14, byungchul wrote:
> const

Done.

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/graph...
File chromecast/public/graphics_types.h (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/graph...
chromecast/public/graphics_types.h:13: : x(arg_x), y(arg_y), width(w), height(h)
{}
On 2015/04/27 21:42:14, byungchul wrote:
> A blank line here

Done.

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/graph...
chromecast/public/graphics_types.h:21: Size(int w, int h) : width(w), height(h)
{}
On 2015/04/27 21:42:14, byungchul wrote:
> ditto

Done.

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/osd_s...
File chromecast/public/osd_surface.h (right):

https://codereview.chromium.org/1104853002/diff/20001/chromecast/public/osd_s...
chromecast/public/osd_surface.h:19: Point(int arg_x, int arg_y) : x(arg_x),
y(arg_y) {}
On 2015/04/27 21:42:14, byungchul wrote:
> a blank line

Done.

[halliwell, 2015-04-28 16:45:57]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2015-04-28 16:45:57]

The patchset sent to the CQ was uploaded after l-g-t-m from gunsch@chromium.org,
byungchul@chromium.org
Link to the patchset: https://codereview.chromium.org/1104853002/#ps40001
(title: "Fix some nits")

[commit-bot: I haz the power, 2015-04-28 16:46:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104853002/40001

[commit-bot: I haz the power, 2015-04-28 16:59:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 17:01:45]

Patchset 3 (id:??) landed as
https://crrev.com/3da8f19ab50e6416f0691f34fe45b007dd886e59
Cr-Commit-Position: refs/heads/master@{#327306}