Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1104813004: Lazily register prototype users (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Lazily register prototype users when handing out validity cells to handles; because invalidating said cells is the only time we'll need the user registrations. Along the way, fix a corner case in WeakFixedArray, which can now be empty after the recently introduced compaction support. Committed: https://crrev.com/a4bb7643c076b014816431a9b85af3e2edf828e7 Cr-Commit-Position: refs/heads/master@{#28047}

Patch Set 1 #

Patch Set 2 : rebased (no conflicts) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -76 lines) Patch
M src/objects.h View 1 5 chunks +16 lines, -8 lines 0 comments Download
M src/objects.cc View 1 13 chunks +107 lines, -68 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/prototype-changes.js View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
PTAL.
5 years, 8 months ago (2015-04-24 11:55:02 UTC) #2
Yang
lgtm.
5 years, 8 months ago (2015-04-24 12:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104813004/20001
5 years, 8 months ago (2015-04-24 12:20:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 12:52:00 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a4bb7643c076b014816431a9b85af3e2edf828e7 Cr-Commit-Position: refs/heads/master@{#28047}
5 years, 8 months ago (2015-04-24 12:52:17 UTC) #8
Jakob Kummerow
5 years, 8 months ago (2015-04-24 14:09:47 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1108583002/ by jkummerow@chromium.org.

The reason for reverting is: Suspected of causing GC stress failures..

Powered by Google App Engine
This is Rietveld 408576698