Issue 11048053: Fix IE version check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11048053: Fix IE version check. (Closed)

Created:
8 years, 2 months ago by grt (UTC plus 2)

Modified:
8 years, 2 months ago

Reviewers:
robertshield

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix IE version check. BUG=155501 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161568

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
	M	chrome_frame/test/chrome_frame_test_utils.cc	View		2 chunks	+19 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11048053/1

8 years, 2 months ago (2012-10-12 12:56:44 UTC) #3

commit-bot: I haz the power

8 years, 2 months ago (2012-10-12 12:56:47 UTC) #4

Presubmit check for 11048053-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome_frame/test/chrome_frame_test_utils.cc:425
    chrome_frame/test/chrome_frame_test_utils.cc:426
    chrome_frame/test/chrome_frame_test_utils.cc:431

Expand Messages | Collapse Messages