Issue 11048052: Merge 130511 - Web Inspector: [Styles] Unable to edit properties in broken stylesheets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11048052: Merge 130511 - Web Inspector: [Styles] Unable to edit properties in broken stylesheets (Closed)

Created:
8 years, 2 months ago by apavlov

Modified:
8 years, 2 months ago

Reviewers:
apavlov

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/

Visibility:
Public.

More Reviews

Description

Merge 130511 - Web Inspector: [Styles] Unable to edit properties in broken stylesheets https://bugs.webkit.org/show_bug.cgi?id=98246 Reviewed by Vsevolod Vlasov. Source/WebCore: Pop source data for invalid rules off the stack whenever we have consecutive CSSParser::markRuleHeaderStart() invocations. Test: inspector/styles/parse-stylesheet-errors.html * css/CSSParser.cpp: (WebCore::CSSParser::popRuleData): (WebCore::CSSParser::markRuleHeaderStart): (WebCore::CSSParser::markRuleBodyStart): * css/CSSParser.h: (CSSParser): TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131163

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	Source/WebCore/css/CSSParser.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/WebCore/css/CSSParser.cpp	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages