Dont' suffix version number with username on production builds

tools/release/version.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file contains functionality for getting dart version numbers using
  * our standard version construction method. Systems that does not include this
  * file should emulate the structure for revision numbers that we have here.
  *
  * The version number of a dart build is constructed as follows:
@@ skipping 134 matching lines @@
     command = "$command${getExecutableSuffix()}";
     var arguments = isSvn ? ["info"] : ["svn", "info"];
     return Process.run(command, arguments).transform((result) {
       if (result.exitCode != 0) {
         return 0;
       }
       return getRevisionFromSvnInfo(result.stdout);
     });
   }
 
+  bool isProductionBuild(String username) {
+    return username == "chrome-bot";
+  }
+
   String getUserName() {
     // TODO(ricow): Don't add this on the buildbot.
     var key = "USER";
     if (Platform.operatingSystem == 'windows') {
       key = "USERNAME";
     }
     if (!Platform.environment.containsKey(key)) return "";
-    return Platform.environment[key];
+    var username = Platform.environment[key];
+    // If this is a production build, i.e., this is something we are shipping,
+    // don't suffix  the version with the username.
+    if (isProductionBuild(username)) return "";
+    return username;
   }
 
   RepositoryType get repositoryType {
     if (new Directory(".svn").existsSync()) return RepositoryType.SVN;
     if (new Directory(".git").existsSync()) return RepositoryType.GIT;
     return RepositoryType.UNKNOWN;
   }
 }
 
 class RepositoryType {
   static final RepositoryType SVN = const RepositoryType("SVN");
   static final RepositoryType GIT = const RepositoryType("GIT");
   static final RepositoryType UNKNOWN = const RepositoryType("UNKNOWN");
 
   const RepositoryType(String this.name);
 
   static RepositoryType guessType() {
     if (new Directory(".svn").existsSync()) return RepositoryType.SVN;
     if (new Directory(".git").existsSync()) return RepositoryType.GIT;
     return RepositoryType.UNKNOWN;
   }
 
   String toString() => name;
 
   final String name;
 }