Allow settings dialog to be opened via the app launcher, as a packaged app.

chrome/browser/ui/extensions/shell_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/shell_window.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/shell_window_geometry_cache.h"
@@ skipping 50 matching lines @@
       base::Bind(&ResourceDispatcherHost::BlockRequestsForRoute,
           base::Unretained(ResourceDispatcherHost::Get()),
           rvh->GetProcess()->GetID(), rvh->GetRoutingID()));
 }
 
 }  // namespace
 
 ShellWindow::CreateParams::CreateParams()
   : frame(ShellWindow::CreateParams::FRAME_CHROME),
     bounds(-1, -1, kDefaultWidth, kDefaultHeight),
-    restore_position(true), restore_size(true) {
+    restore_position(true), restore_size(true),
+    creator_process_id(0) {
 }
 
 ShellWindow::CreateParams::~CreateParams() {
 }
 
 ShellWindow* ShellWindow::Create(Profile* profile,
                                  const extensions::Extension* extension,
                                  const GURL& url,
                                  const ShellWindow::CreateParams& params) {
   // This object will delete itself when the window is closed.
@@ skipping 42 matching lines @@
         if (params.restore_position)
           bounds.set_origin(cached_bounds.origin());
         if (params.restore_size)
           bounds.set_size(cached_bounds.size());
 
         native_window_->SetBounds(bounds);
       }
     }
   }
 
-
-  // Block the created RVH from loading anything until the background page
-  // has had a chance to do any initialization it wants.
-  SuspendRenderViewHost(web_contents_->GetRenderViewHost());
+  // If the new view is in the same process as the creator, block the created
+  // RVH from loading anything until the background page has had a chance to do
+  // any initialization it wants. If it's a different process, the new RVH
+  // shouldn't communicate with the background page anyway (e.g. sandboxed).
+  if (web_contents_->GetRenderViewHost()->GetProcess()->GetID()
+      == params.creator_process_id) {

[sky, 2012/10/12 16:30:21]

== on previous line.

[tapted, 2012/10/15 02:32:39]

Done.

+    SuspendRenderViewHost(web_contents_->GetRenderViewHost());
+  } else {
+    DLOG(INFO) << "ShellWindow created in new process ("

[sky, 2012/10/12 16:30:21]

VLOG

[tapted, 2012/10/15 02:32:39]

Done.

+               << web_contents_->GetRenderViewHost()->GetProcess()->GetID()
+               << ") != creator (" << params.creator_process_id
+               << "). Routing disabled.";
+  }
 
   // TODO(jeremya): there's a bug where navigating a web contents to an
   // extension URL causes it to create a new RVH and discard the old (perfectly
   // usable) one. To work around this, we watch for a RVH_CHANGED message from
   // the web contents (which will be sent during LoadURL) and suspend resource
   // requests on the new RVH to ensure that we block the new RVH from loading
   // anything. It should be okay to remove the NOTIFICATION_RVH_CHANGED
   // registration once http://crbug.com/123007 is fixed.
   registrar_.Add(this, content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
                  content::Source<content::NavigationController>(
@@ skipping 324 matching lines @@
   if (window_key_.empty())
     return;
 
   extensions::ShellWindowGeometryCache* cache =
       extensions::ExtensionSystem::Get(profile())->
           shell_window_geometry_cache();
 
   gfx::Rect bounds = native_window_->GetBounds();
   cache->SaveGeometry(extension()->id(), window_key_, bounds);
 }