| Index: cc/CCResourceProvider.cpp
|
| diff --git a/cc/CCResourceProvider.cpp b/cc/CCResourceProvider.cpp
|
| index 29ca7d4373d9579af4f36ab5aa3d1681703c54d7..1922c2f09753b5f524ea2920f3823fa51d85f56b 100644
|
| --- a/cc/CCResourceProvider.cpp
|
| +++ b/cc/CCResourceProvider.cpp
|
| @@ -39,7 +39,7 @@ static GC3Denum textureToStorageFormat(GC3Denum textureFormat)
|
| storageFormat = Extensions3DChromium::BGRA8_EXT;
|
| break;
|
| default:
|
| - ASSERT_NOT_REACHED();
|
| + NOTREACHED();
|
| break;
|
| }
|
|
|
| @@ -128,13 +128,13 @@ CCResourceProvider::~CCResourceProvider()
|
|
|
| WebGraphicsContext3D* CCResourceProvider::graphicsContext3D()
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| return m_context->context3D();
|
| }
|
|
|
| bool CCResourceProvider::inUseByConsumer(ResourceId id)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -151,7 +151,7 @@ CCResourceProvider::ResourceId CCResourceProvider::createResource(int pool, cons
|
| case GLTexture:
|
| return createGLTexture(pool, size, format, hint);
|
| case Bitmap:
|
| - ASSERT(format == GraphicsContext3D::RGBA);
|
| + DCHECK(format == GraphicsContext3D::RGBA);
|
| return createBitmap(pool, size);
|
| }
|
|
|
| @@ -161,10 +161,10 @@ CCResourceProvider::ResourceId CCResourceProvider::createResource(int pool, cons
|
|
|
| CCResourceProvider::ResourceId CCResourceProvider::createGLTexture(int pool, const IntSize& size, GC3Denum format, TextureUsageHint hint)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| unsigned textureId = 0;
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| - ASSERT(context3d);
|
| + DCHECK(context3d);
|
| GLC(context3d, textureId = context3d->createTexture());
|
| GLC(context3d, context3d->bindTexture(GraphicsContext3D::TEXTURE_2D, textureId));
|
| GLC(context3d, context3d->texParameteri(GraphicsContext3D::TEXTURE_2D, GraphicsContext3D::TEXTURE_MIN_FILTER, GraphicsContext3D::LINEAR));
|
| @@ -187,7 +187,7 @@ CCResourceProvider::ResourceId CCResourceProvider::createGLTexture(int pool, con
|
|
|
| CCResourceProvider::ResourceId CCResourceProvider::createBitmap(int pool, const IntSize& size)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
|
|
| uint8_t* pixels = new uint8_t[size.width() * size.height() * 4];
|
|
|
| @@ -199,8 +199,8 @@ CCResourceProvider::ResourceId CCResourceProvider::createBitmap(int pool, const
|
|
|
| CCResourceProvider::ResourceId CCResourceProvider::createResourceFromExternalTexture(unsigned textureId)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| - ASSERT(m_context->context3D());
|
| + DCHECK(CCProxy::isImplThread());
|
| + DCHECK(m_context->context3D());
|
| ResourceId id = m_nextId++;
|
| Resource resource(textureId, 0, IntSize(), 0);
|
| resource.external = true;
|
| @@ -210,7 +210,7 @@ CCResourceProvider::ResourceId CCResourceProvider::createResourceFromExternalTex
|
|
|
| void CCResourceProvider::deleteResource(ResourceId id)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -218,12 +218,12 @@ void CCResourceProvider::deleteResource(ResourceId id)
|
| #else
|
| Resource* resource = &it->second;
|
| #endif
|
| - ASSERT(!resource->lockedForWrite);
|
| - ASSERT(!resource->lockForReadCount);
|
| + DCHECK(!resource->lockedForWrite);
|
| + DCHECK(!resource->lockForReadCount);
|
|
|
| if (resource->glId && !resource->external) {
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| - ASSERT(context3d);
|
| + DCHECK(context3d);
|
| GLC(context3d, context3d->deleteTexture(resource->glId));
|
| }
|
| if (resource->pixels)
|
| @@ -234,7 +234,7 @@ void CCResourceProvider::deleteResource(ResourceId id)
|
|
|
| void CCResourceProvider::deleteOwnedResources(int pool)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceIdArray toDelete;
|
| for (ResourceMap::iterator it = m_resources.begin(); it != m_resources.end(); ++it) {
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -263,7 +263,7 @@ CCResourceProvider::ResourceType CCResourceProvider::resourceType(ResourceId id)
|
|
|
| void CCResourceProvider::upload(ResourceId id, const uint8_t* image, const IntRect& imageRect, const IntRect& sourceRect, const IntSize& destOffset)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -271,14 +271,14 @@ void CCResourceProvider::upload(ResourceId id, const uint8_t* image, const IntRe
|
| #else
|
| Resource* resource = &it->second;
|
| #endif
|
| - ASSERT(!resource->lockedForWrite);
|
| - ASSERT(!resource->lockForReadCount);
|
| - ASSERT(!resource->external);
|
| + DCHECK(!resource->lockedForWrite);
|
| + DCHECK(!resource->lockForReadCount);
|
| + DCHECK(!resource->external);
|
|
|
| if (resource->glId) {
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| - ASSERT(context3d);
|
| - ASSERT(m_texSubImage.get());
|
| + DCHECK(context3d);
|
| + DCHECK(m_texSubImage.get());
|
| context3d->bindTexture(GraphicsContext3D::TEXTURE_2D, resource->glId);
|
| m_texSubImage->upload(image, imageRect, sourceRect, destOffset, resource->format, context3d);
|
| }
|
| @@ -300,7 +300,7 @@ void CCResourceProvider::upload(ResourceId id, const uint8_t* image, const IntRe
|
|
|
| void CCResourceProvider::flush()
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| if (context3d)
|
| context3d->flush();
|
| @@ -308,7 +308,7 @@ void CCResourceProvider::flush()
|
|
|
| bool CCResourceProvider::shallowFlushIfSupported()
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| if (!context3d || !m_useShallowFlush)
|
| return false;
|
| @@ -319,7 +319,7 @@ bool CCResourceProvider::shallowFlushIfSupported()
|
|
|
| const CCResourceProvider::Resource* CCResourceProvider::lockForRead(ResourceId id)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
|
|
| @@ -328,14 +328,14 @@ const CCResourceProvider::Resource* CCResourceProvider::lockForRead(ResourceId i
|
| #else
|
| Resource* resource = &it->second;
|
| #endif
|
| - ASSERT(!resource->lockedForWrite);
|
| + DCHECK(!resource->lockedForWrite);
|
| resource->lockForReadCount++;
|
| return resource;
|
| }
|
|
|
| void CCResourceProvider::unlockForRead(ResourceId id)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -343,13 +343,13 @@ void CCResourceProvider::unlockForRead(ResourceId id)
|
| #else
|
| Resource* resource = &it->second;
|
| #endif
|
| - ASSERT(resource->lockForReadCount > 0);
|
| + DCHECK(resource->lockForReadCount > 0);
|
| resource->lockForReadCount--;
|
| }
|
|
|
| const CCResourceProvider::Resource* CCResourceProvider::lockForWrite(ResourceId id)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -357,16 +357,16 @@ const CCResourceProvider::Resource* CCResourceProvider::lockForWrite(ResourceId
|
| #else
|
| Resource* resource = &it->second;
|
| #endif
|
| - ASSERT(!resource->lockedForWrite);
|
| - ASSERT(!resource->lockForReadCount);
|
| - ASSERT(!resource->external);
|
| + DCHECK(!resource->lockedForWrite);
|
| + DCHECK(!resource->lockForReadCount);
|
| + DCHECK(!resource->external);
|
| resource->lockedForWrite = true;
|
| return resource;
|
| }
|
|
|
| void CCResourceProvider::unlockForWrite(ResourceId id)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -374,8 +374,8 @@ void CCResourceProvider::unlockForWrite(ResourceId id)
|
| #else
|
| Resource* resource = &it->second;
|
| #endif
|
| - ASSERT(resource->lockedForWrite);
|
| - ASSERT(!resource->external);
|
| + DCHECK(resource->lockedForWrite);
|
| + DCHECK(!resource->external);
|
| resource->lockedForWrite = false;
|
| }
|
|
|
| @@ -384,7 +384,7 @@ CCResourceProvider::ScopedReadLockGL::ScopedReadLockGL(CCResourceProvider* resou
|
| , m_resourceId(resourceId)
|
| , m_textureId(resourceProvider->lockForRead(resourceId)->glId)
|
| {
|
| - ASSERT(m_textureId);
|
| + DCHECK(m_textureId);
|
| }
|
|
|
| CCResourceProvider::ScopedReadLockGL::~ScopedReadLockGL()
|
| @@ -397,7 +397,7 @@ CCResourceProvider::ScopedWriteLockGL::ScopedWriteLockGL(CCResourceProvider* res
|
| , m_resourceId(resourceId)
|
| , m_textureId(resourceProvider->lockForWrite(resourceId)->glId)
|
| {
|
| - ASSERT(m_textureId);
|
| + DCHECK(m_textureId);
|
| }
|
|
|
| CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL()
|
| @@ -407,8 +407,8 @@ CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL()
|
|
|
| void CCResourceProvider::populateSkBitmapWithResource(SkBitmap* skBitmap, const Resource* resource)
|
| {
|
| - ASSERT(resource->pixels);
|
| - ASSERT(resource->format == GraphicsContext3D::RGBA);
|
| + DCHECK(resource->pixels);
|
| + DCHECK(resource->format == GraphicsContext3D::RGBA);
|
| skBitmap->setConfig(SkBitmap::kARGB_8888_Config, resource->size.width(), resource->size.height());
|
| skBitmap->setPixels(resource->pixels);
|
| }
|
| @@ -452,7 +452,7 @@ CCResourceProvider::CCResourceProvider(CCGraphicsContext* context)
|
|
|
| bool CCResourceProvider::initialize()
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| if (!context3d) {
|
| m_maxTextureSize = INT_MAX / 2;
|
| @@ -490,7 +490,7 @@ bool CCResourceProvider::initialize()
|
|
|
| int CCResourceProvider::createChild(int pool)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| Child childInfo;
|
| childInfo.pool = pool;
|
| int child = m_nextChild++;
|
| @@ -500,9 +500,9 @@ int CCResourceProvider::createChild(int pool)
|
|
|
| void CCResourceProvider::destroyChild(int child)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ChildMap::iterator it = m_children.find(child);
|
| - ASSERT(it != m_children.end());
|
| + DCHECK(it != m_children.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| deleteOwnedResources(it->value.pool);
|
| #else
|
| @@ -514,9 +514,9 @@ void CCResourceProvider::destroyChild(int child)
|
|
|
| const CCResourceProvider::ResourceIdMap& CCResourceProvider::getChildToParentMap(int child) const
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ChildMap::const_iterator it = m_children.find(child);
|
| - ASSERT(it != m_children.end());
|
| + DCHECK(it != m_children.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| return it->value.childToParentMap;
|
| #else
|
| @@ -526,7 +526,7 @@ const CCResourceProvider::ResourceIdMap& CCResourceProvider::getChildToParentMap
|
|
|
| CCResourceProvider::TransferableResourceList CCResourceProvider::prepareSendToParent(const ResourceIdArray& resources)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| TransferableResourceList list;
|
| list.syncPoint = 0;
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| @@ -552,7 +552,7 @@ CCResourceProvider::TransferableResourceList CCResourceProvider::prepareSendToPa
|
|
|
| CCResourceProvider::TransferableResourceList CCResourceProvider::prepareSendToChild(int child, const ResourceIdArray& resources)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| TransferableResourceList list;
|
| list.syncPoint = 0;
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| @@ -568,7 +568,7 @@ CCResourceProvider::TransferableResourceList CCResourceProvider::prepareSendToCh
|
| for (ResourceIdArray::const_iterator it = resources.begin(); it != resources.end(); ++it) {
|
| TransferableResource resource;
|
| if (!transferResource(context3d, *it, &resource))
|
| - ASSERT_NOT_REACHED();
|
| + NOTREACHED();
|
| resource.id = childInfo.parentToChildMap.get(*it);
|
| childInfo.parentToChildMap.remove(*it);
|
| childInfo.childToParentMap.remove(resource.id);
|
| @@ -582,7 +582,7 @@ CCResourceProvider::TransferableResourceList CCResourceProvider::prepareSendToCh
|
|
|
| void CCResourceProvider::receiveFromChild(int child, const TransferableResourceList& resources)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| if (!context3d || !context3d->makeContextCurrent()) {
|
| // FIXME: Implement this path for software compositing.
|
| @@ -618,7 +618,7 @@ void CCResourceProvider::receiveFromChild(int child, const TransferableResourceL
|
|
|
| void CCResourceProvider::receiveFromParent(const TransferableResourceList& resources)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| WebGraphicsContext3D* context3d = m_context->context3D();
|
| if (!context3d || !context3d->makeContextCurrent()) {
|
| // FIXME: Implement this path for software compositing.
|
| @@ -632,7 +632,7 @@ void CCResourceProvider::receiveFromParent(const TransferableResourceList& resou
|
| #else
|
| Resource* resource = &m_resources.find(it->id)->second;
|
| #endif
|
| - ASSERT(resource->exported);
|
| + DCHECK(resource->exported);
|
| resource->exported = false;
|
| GLC(context3d, context3d->bindTexture(GraphicsContext3D::TEXTURE_2D, resource->glId));
|
| GLC(context3d, context3d->consumeTextureCHROMIUM(GraphicsContext3D::TEXTURE_2D, it->mailbox.name));
|
| @@ -642,7 +642,7 @@ void CCResourceProvider::receiveFromParent(const TransferableResourceList& resou
|
|
|
| bool CCResourceProvider::transferResource(WebGraphicsContext3D* context, ResourceId id, TransferableResource* resource)
|
| {
|
| - ASSERT(CCProxy::isImplThread());
|
| + DCHECK(CCProxy::isImplThread());
|
| ResourceMap::const_iterator it = m_resources.find(id);
|
| CHECK(it != m_resources.end());
|
| #if WTF_NEW_HASHMAP_ITERATORS_INTERFACE
|
| @@ -650,9 +650,9 @@ bool CCResourceProvider::transferResource(WebGraphicsContext3D* context, Resourc
|
| #else
|
| const Resource* source = &it->second;
|
| #endif
|
| - ASSERT(!source->lockedForWrite);
|
| - ASSERT(!source->lockForReadCount);
|
| - ASSERT(!source->external);
|
| + DCHECK(!source->lockedForWrite);
|
| + DCHECK(!source->lockForReadCount);
|
| + DCHECK(!source->external);
|
| if (source->exported)
|
| return false;
|
| resource->id = id;
|
|
|