Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: cc/CCLayerTreeHostCommon.cpp

Issue 11048044: cc: Switch to Chromium DCHECKs and LOGs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/CCLayerTreeHostCommon.cpp
diff --git a/cc/CCLayerTreeHostCommon.cpp b/cc/CCLayerTreeHostCommon.cpp
index 24274a6f6f59f4213fdfc1fe73a6070a74b84329..36c0ae675a97f4ea48c68b59f67f5b2a88f2bbf4 100644
--- a/cc/CCLayerTreeHostCommon.cpp
+++ b/cc/CCLayerTreeHostCommon.cpp
@@ -112,7 +112,7 @@ static inline bool layerClipsSubtree(LayerType* layer)
template<typename LayerType>
static IntRect calculateVisibleContentRect(LayerType* layer)
{
- ASSERT(layer->renderTarget());
+ DCHECK(layer->renderTarget());
// Nothing is visible if the layer bounds are empty.
if (!layer->drawsContent() || layer->contentBounds().isEmpty() || layer->drawableContentRect().isEmpty())
@@ -187,8 +187,8 @@ static bool layerShouldBeSkipped(LayerType* layer)
LayerType* backfaceTestLayer = layer;
if (layer->useParentBackfaceVisibility()) {
- ASSERT(layer->parent());
- ASSERT(!layer->parent()->useParentBackfaceVisibility());
+ DCHECK(layer->parent());
+ DCHECK(!layer->parent()->useParentBackfaceVisibility());
backfaceTestLayer = layer->parent();
}
@@ -354,7 +354,7 @@ void setupRootLayerAndSurfaceForRecursion(LayerType* rootLayer, LayerList& rende
rootLayer->renderSurface()->setContentRect(IntRect(IntPoint::zero(), deviceViewportSize));
rootLayer->renderSurface()->clearLayerLists();
- ASSERT(renderSurfaceLayerList.empty());
+ DCHECK(renderSurfaceLayerList.empty());
renderSurfaceLayerList.push_back(rootLayer);
}
@@ -599,7 +599,7 @@ static void calculateDrawTransformsInternal(LayerType* layer, LayerType* rootLay
layer->setDrawOpacityIsAnimating(drawOpacityIsAnimating);
if (layer != rootLayer) {
- ASSERT(layer->parent());
+ DCHECK(layer->parent());
layer->clearRenderSurface();
// Layers without renderSurfaces directly inherit the ancestor's clip status.
@@ -611,9 +611,9 @@ static void calculateDrawTransformsInternal(LayerType* layer, LayerType* rootLay
layer->setRenderTarget(layer->parent()->renderTarget());
} else {
// FIXME: This root layer special case code should eventually go away. https://bugs.webkit.org/show_bug.cgi?id=92290
- ASSERT(!layer->parent());
- ASSERT(layer->renderSurface());
- ASSERT(ancestorClipsSubtree);
+ DCHECK(!layer->parent());
+ DCHECK(layer->renderSurface());
+ DCHECK(ancestorClipsSubtree);
layer->renderSurface()->setClipRect(clipRectFromAncestor);
subtreeShouldBeClipped = false;
}
@@ -737,7 +737,7 @@ static void calculateDrawTransformsInternal(LayerType* layer, LayerType* rootLay
renderSurfaceLayerList.back()->clearRenderSurface();
renderSurfaceLayerList.pop_back();
}
- ASSERT(renderSurfaceLayerList.back() == layer);
+ DCHECK(renderSurfaceLayerList.back() == layer);
renderSurfaceLayerList.pop_back();
layer->clearRenderSurface();
return;

Powered by Google App Engine
This is Rietveld 408576698