cc: Switch to Chromium DCHECKs and LOGs

cc/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for cc.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into gcl.
 """
 
+import re
+
+def CheckNoDcheck(input_api, output_api, white_list=None, black_list=None):
+  white_list = tuple(white_list or ('^cc/.*\.(cc|h)$',))

[enne (OOO), 2012/10/16 18:34:22]

nit: r'^cc...

Also, what about just sticking these as the default args, e.g. white_list =
CC_SOURCE_FILES, black_list=input_api.DEFAULT_BLACK_LIST?

[danakj, 2012/10/16 19:11:51]

Aded CC_SOURCE_FILES. The black_list has to stay the same, can't refer to other
parameters when trying to set a default parameter value.

+  black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
+  source_file_filter = lambda x: input_api.FilterSourceFile(x, white_list, black_list)
+  
+  bad_files = []
+  for f in input_api.AffectedSourceFiles(source_file_filter):
+    contents = input_api.ReadFile(f, 'rb')
+    if re.search(r"(?<!CC_)DCHECK", contents):
+      bad_files.append(f.LocalPath())
+  if bad_files:
+    return [output_api.PresubmitPromptWarning(
+      'These files use DCHECK instead of using CC_DCHECK:',
+      items=bad_files)]
+  return []
+
+def CheckChangeOnUpload(input_api, output_api):
+  results = []
+  results += CheckNoDcheck(input_api, output_api)
+  return results
+
 def GetPreferredTrySlaves(project, change):
   return [
     'linux_layout_rel',
     ]