Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1104803002: Oilpan: expand size of vector backing container when finalizing. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: expand size of vector backing container when finalizing. The finalization of vector buffers will currently finalize all slots in the buffer, as the actually used subsequence cannot be determined by the buffer. Hence, the buffer finalization needs to expand the size of the container before iterating over the slots so as to avoid ASan container overflow checks reporting false negatives. R=haraken BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. Addresses https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/797/layout-test-results/svg/css/cursor-image-replace-crash-log.txt
5 years, 8 months ago (2015-04-24 07:00:59 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-24 08:01:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104803002/1
5 years, 8 months ago (2015-04-24 08:08:23 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 08:13:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194360

Powered by Google App Engine
This is Rietveld 408576698