Chromium Code Reviews
Help | Chromium Project | Sign in
(655)

Issue 11048018: Add "standalone_static_library" target flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Nico
Modified:
1 year, 6 months ago
Reviewers:
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add "standalone_static_library" target flag

This flag is only valid for targets of type "static_library"

Adding 'standalone_static_library': 1, ensures:
1) "thin" archive optimisation is disabled for this target (it will contain
symbols)
2) The static_library will be "installed" to PRODUCT_DIR

Review URL: http://codereview.chromium.org/11031005/
Patch from Eric Boren <borenet@google.com>!
Committed: https://code.google.com/p/gyp/source/detail?r=1510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -9 lines) Lint Patch
M pylib/gyp/generator/make.py View 5 chunks +22 lines, -6 lines 0 comments 0 errors Download
M pylib/gyp/generator/ninja.py View 4 chunks +13 lines, -3 lines 0 comments 0 errors Download
M pylib/gyp/input.py View 3 chunks +7 lines, -0 lines 0 comments 0 errors Download
M test/configurations/invalid/gyptest-configurations.py View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
A test/configurations/invalid/standalone_static_library.gyp View 1 chunk +17 lines, -0 lines 0 comments 0 errors Download
A test/standalone-static-library/gyptest-standalone-static-library.py View 1 chunk +35 lines, -0 lines 0 comments 0 errors Download
A test/standalone-static-library/mylib.c View 1 chunk +7 lines, -0 lines 0 comments 2 errors Download
A test/standalone-static-library/mylib.gyp View 1 chunk +26 lines, -0 lines 0 comments 0 errors Download
A test/standalone-static-library/prog.c View 1 chunk +7 lines, -0 lines 0 comments 2 errors Download
Trybot results:
Commit:

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6