patch_sdk: fix part/import order

patch_sdk: fix part/import order
gets rid of one case of errors

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/47006c3ec43793a91c7e17b8ffaaa616c6175a66

[Jennifer Messerly, 2015-04-23 20:35:13]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2015-04-23 21:32:55]

https://codereview.chromium.org/1104753002/diff/1/tool/patch_sdk.dart
File tool/patch_sdk.dart (right):

https://codereview.chromium.org/1104753002/diff/1/tool/patch_sdk.dart#newcode173
tool/patch_sdk.dart:173: int partPos = unit.directives.last.end;
I think directives can be null if there are no directives?  Not sure if it can
be non-null and empty.

https://codereview.chromium.org/1104753002/diff/1/tool/patch_sdk.dart#newcode176
tool/patch_sdk.dart:176: int importPos = lastImport != null ? lastImport.end :
partPos;
Doesn't this still put the new imports after the parts if there no imports in
the original file?

[Jennifer Messerly, 2015-04-23 21:44:28]

PTAL

https://codereview.chromium.org/1104753002/diff/1/tool/patch_sdk.dart
File tool/patch_sdk.dart (right):

https://codereview.chromium.org/1104753002/diff/1/tool/patch_sdk.dart#newcode173
tool/patch_sdk.dart:173: int partPos = unit.directives.last.end;
On 2015/04/23 21:32:55, leafp wrote:
> I think directives can be null if there are no directives?  Not sure if it can
> be non-null and empty.

maybe, yeah. That can only happen for "scripts" though (the entry point).
Everyone else needs at least a library directive.

https://codereview.chromium.org/1104753002/diff/1/tool/patch_sdk.dart#newcode176
tool/patch_sdk.dart:176: int importPos = lastImport != null ? lastImport.end :
partPos;
On 2015/04/23 21:32:55, leafp wrote:
> Doesn't this still put the new imports after the parts if there no imports in
> the original file?

Good catch! I'll have it go after the library directive instead.

[Leaf, 2015-04-23 22:03:15]

lgtm

[Jennifer Messerly, 2015-04-27 23:56:12]

Committed patchset #2 (id:20001) manually as
47006c3ec43793a91c7e17b8ffaaa616c6175a66 (presubmit successful).