Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1104733002: Revert of mac: Tentative fix for Yosemite open file crash. (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
Reviewers:
Avi (use Gerrit), Andre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Tentative fix for Yosemite open file crash. (patchset #5 id:70001 of https://codereview.chromium.org/941453002/) Reason for revert: Speculative revert. This CL might be responsible for inverted text in omnibox. https://code.google.com/p/chromium/issues/detail?id=479097 Original issue's description: > mac: Tentative fix for Yosemite open file crash. > > There's a bug in AppKit that causes Chrome to crash when users attempt to save > or open a file. The code path that causes the crash is only hit by applications > linked against OSX 10.7 SDK (or earlier). This CL registers a default value for > the preference NSViewKeepLayersAround, which prevents this code path from being > hit. The functional implications of changing the preference > NSViewKeepLayersAround are minimal. > > BUG=428977 > > Committed: https://crrev.com/192b9d9cfe388a6cfb76b9aea56070da1d878a81 > Cr-Commit-Position: refs/heads/master@{#316968} TBR=andresantoso@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428977 Committed: https://crrev.com/e771ecf956c01834866e5c1caaad97977ca6fda4 Cr-Commit-Position: refs/heads/master@{#326585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
erikchen
Created Revert of mac: Tentative fix for Yosemite open file crash.
5 years, 8 months ago (2015-04-23 18:23:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104733002/1
5 years, 8 months ago (2015-04-23 18:25:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 18:27:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e771ecf956c01834866e5c1caaad97977ca6fda4 Cr-Commit-Position: refs/heads/master@{#326585}
5 years, 8 months ago (2015-04-23 18:28:54 UTC) #4
Andre
5 years, 8 months ago (2015-04-24 00:11:12 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698