Actually use --extra-r-text-files in process_resources.py

build/android/gyp/process_resources.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Process Android resources to generate R.java, and prepare for packaging.
 
 This will crunch images and generate v14 compatible resources
 (see generate_v14_compatible_resources.py).
 """
 
-import codecs
 import optparse
 import os
 import re
 import shutil
+from string import Template
 import sys
 import zipfile
 
 import generate_v14_compatible_resources
 
 from util import build_utils
 
 
 def ParseArgs(args):
   """Parses command line options.
@@ skipping 22 matching lines @@
   parser.add_option('--dependencies-res-zips',
                     help='Resources from dependents.')
 
   parser.add_option('--resource-zip-out',
                     help='Path for output zipped resources.')
 
   parser.add_option('--R-dir',
                     help='directory to hold generated R.java.')
   parser.add_option('--srcjar-out',
                     help='Path to srcjar to contain generated R.java.')
+  parser.add_option('--r-text-out',
+                    help='Path to store the R.txt file generated by appt.')
 
   parser.add_option('--proguard-file',
                     help='Path to proguard.txt generated file')
 
   parser.add_option(
       '--v14-verify-only',
       action='store_true',
       help='Do not generate v14 resources. Instead, just verify that the '
       'resources are already compatible with v14, i.e. they don\'t use '
       'attributes that cause crashes on certain devices.')
 
   parser.add_option(
       '--extra-res-packages',
       help='Additional package names to generate R.java files for')
-  # TODO(cjhopman): Actually use --extra-r-text-files. We currently include all
-  # the resources in all R.java files for a particular apk.
   parser.add_option(
       '--extra-r-text-files',
       help='For each additional package, the R.txt file should contain a '
       'list of resources to be included in the R.java file in the format '
       'generated by aapt')
 
   parser.add_option(
       '--all-resources-zip-out',
       help='Path for output of all resources. This includes resources in '
       'dependencies.')
@@ skipping 15 matching lines @@
       'resource_zip_out',
       )
   build_utils.CheckOptions(options, parser, required=required_options)
 
   if (options.R_dir is None) == (options.srcjar_out is None):
     raise Exception('Exactly one of --R-dir or --srcjar-out must be specified.')
 
   return options
 
 
-def CreateExtraRJavaFiles(r_dir, extra_packages):
-  java_files = build_utils.FindInDirectory(r_dir, "R.java")
-  if len(java_files) != 1:
+def CreateExtraRJavaFiles(r_dir, extra_packages, extra_r_text_files):
+  r_txt_files = build_utils.FindInDirectory(r_dir, 'R.txt')

[cjhopman, 2015/04/27 18:34:47]

Below you find the R.txt by just doing os.path.join(r_dir, 'R.txt'). why not do
that here too?

[Ian Cullinan, 2015/04/27 18:58:46]

Acknowledged.

+  if len(r_txt_files) != 1:
     return
-  r_java_file = java_files[0]
-  r_java_contents = codecs.open(r_java_file, encoding='utf-8').read()
+  if len(extra_packages) != len(extra_r_text_files):
+    raise Exception('Need one R.txt file per extra package')
 
-  for package in extra_packages:
+  all_resources = {}
+  with open(r_txt_files[0]) as f:
+    for line in f:
+      m = re.match(r'(int(?:\[\])?) (\w+) (\w+) (.+)$', line)
+      if not m:
+        raise Exception('Unexpected line in R.txt: %s' % line)
+      java_type, resource_type, name, value = m.groups()
+      all_resources[(resource_type, name)] = (java_type, value)
+
+  for package, r_text_file in zip(extra_packages, extra_r_text_files):
     package_r_java_dir = os.path.join(r_dir, *package.split('.'))
     build_utils.MakeDirectory(package_r_java_dir)
     package_r_java_path = os.path.join(package_r_java_dir, 'R.java')
-    new_r_java = re.sub(r'package [.\w]*;', u'package %s;' % package,
-                        r_java_contents)
-    codecs.open(package_r_java_path, 'w', encoding='utf-8').write(new_r_java)
-    # TODO(cjhopman): These extra package's R.java files should be filtered to
-    # only contain the resources listed in their R.txt files. At this point, we
-    # have already compiled those other libraries, so doing this would only
-    # affect how the code in this .apk target could refer to the resources.
+    CreateExtraRJavaFile(
+        package, package_r_java_path, r_text_file, all_resources)
+
+
+def CreateExtraRJavaFile(package, r_java_path, r_text_file, all_resources):
+  resources = {}
+  with open(r_text_file) as f:
+    for line in f:
+      m = re.match(r'int(?:\[\])? (\w+) (\w+) ', line)
+      if not m:
+        raise Exception('Unexpected line in R.txt: %s' % line)
+      resource_type, name = m.groups()
+      if resource_type not in resources:
+        resources[resource_type] = []
+      resources[resource_type].append(name)
+
+  template = Template("""/* AUTO-GENERATED FILE.  DO NOT MODIFY. */
+
+package ${PACKAGE};
+
+public final class R {
+${RESOURCE_CLASSES}
+}
+""")
+
+  class_template = Template("""    public static final class ${RESOURCE_TYPE} {
+${RESOURCES}
+    }
+""")
+
+  resource_template = Template(
+      '        public static final ${TYPE} ${NAME} = ${VALUE};')
+  resource_classes = []
+  for resource_type in sorted(resources.keys()):
+    resource_strings = []
+    for name in resources[resource_type]:
+      java_type, value = all_resources[(resource_type, name)]
+      values = {
+          'TYPE': java_type,
+          'NAME': name,
+          'VALUE': value
+      }
+      resource_strings.append(resource_template.substitute(values))
+    values = {
+        'RESOURCE_TYPE': resource_type,
+        'RESOURCES': '\n'.join(resource_strings)
+    }
+    resource_classes.append(class_template.substitute(values))
+  values = {
+      'PACKAGE': package,
+      'RESOURCE_CLASSES': '\n'.join(resource_classes)
+  }
+  with open(r_java_path, 'w') as f:
+    f.write(template.substitute(values))
 
 
 def CrunchDirectory(aapt, input_dir, output_dir):
   """Crunches the images in input_dir and its subdirectories into output_dir.
 
   If an image is already optimized, crunching often increases image size. In
   this case, the crunched image is overwritten with the original image.
   """
   aapt_cmd = [aapt,
               'crunch',
@@ skipping 134 matching lines @@
       package_command += ['--custom-package', options.custom_package]
     if options.proguard_file:
       package_command += ['-G', options.proguard_file]
     if options.shared_resources:
       package_command.append('--shared-lib')
     build_utils.CheckOutput(package_command, print_stderr=False)
 
     if options.extra_res_packages:
       CreateExtraRJavaFiles(
           gen_dir,
-          build_utils.ParseGypList(options.extra_res_packages))
+          build_utils.ParseGypList(options.extra_res_packages),
+          build_utils.ParseGypList(options.extra_r_text_files))
 
     # This is the list of directories with resources to put in the final .zip
     # file. The order of these is important so that crunched/v14 resources
     # override the normal ones.
     zip_resource_dirs = input_resource_dirs + [v14_dir]
 
     base_crunch_dir = os.path.join(temp_dir, 'crunch')
 
     # Crunch image resources. This shrinks png files and is necessary for
     # 9-patch images to display correctly. 'aapt crunch' accepts only a single
     # directory at a time and deletes everything in the output directory.
     for idx, input_dir in enumerate(input_resource_dirs):
       crunch_dir = os.path.join(base_crunch_dir, str(idx))
       build_utils.MakeDirectory(crunch_dir)
       zip_resource_dirs.append(crunch_dir)
       CrunchDirectory(aapt, input_dir, crunch_dir)
 
     ZipResources(zip_resource_dirs, options.resource_zip_out)
 
     if options.all_resources_zip_out:
       CombineZips([options.resource_zip_out] + dep_zips,
                   options.all_resources_zip_out)
 
     if options.R_dir:
       build_utils.DeleteDirectory(options.R_dir)
       shutil.copytree(gen_dir, options.R_dir)
     else:
       build_utils.ZipDir(options.srcjar_out, gen_dir)
 
+    if options.r_text_out:
+      r_text_path = os.path.join(gen_dir, 'R.txt')
+      shutil.copyfile(r_text_path, options.r_text_out)
+
   if options.depfile:
     input_files += build_utils.GetPythonDependencies()
     build_utils.WriteDepfile(options.depfile, input_files)
 
   if options.stamp:
     build_utils.Touch(options.stamp)
 
 
 if __name__ == '__main__':
   main()