Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11047013: Minor fixes to test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 795f242297c9b00c8578688c5341cd2937eec921..b2f25ee741b3424e3b03e78c8fd39f14c600fd41 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -46,7 +46,7 @@ typedef void VoidFunction();
* Most TestSuites represent a directory or directory tree containing tests,
* and a status file containing the expected results when these tests are run.
*/
-interface TestSuite {
+abstract class TestSuite {
/**
* Call the callback function onTest with a [TestCase] argument for each
* test in the suite. When all tests have been processed, call [onDone].
@@ -832,8 +832,6 @@ class StandardTestSuite implements TestSuite {
bool get hasRuntime {
switch(configuration['runtime']) {
- case null:
- Expect.fail("configuration['runtime'] is not set");
ricow1 2012/10/03 10:39:03 if we don't pass runtime in on the command line do
Mads Ager (google) 2012/10/03 10:44:10 At this point I'm just cleaning this up. 'runtime'
case 'none':
return false;
default:
@@ -1335,6 +1333,7 @@ class TestUtils {
} else {
return '${prefix}dart2js$suffix';
}
+ break;
default:
throw "Unknown executable for: ${configuration['compiler']}";
}
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698