Minor fixes to test.dart.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 28 matching lines @@
 
 typedef void VoidFunction();
 
 /**
  * A TestSuite represents a collection of tests.  It creates a [TestCase]
  * object for each test to be run, and passes the test cases to a callback.
  *
  * Most TestSuites represent a directory or directory tree containing tests,
  * and a status file containing the expected results when these tests are run.
  */
-interface TestSuite {
+abstract class TestSuite {
   /**
    * Call the callback function onTest with a [TestCase] argument for each
    * test in the suite.  When all tests have been processed, call [onDone].
    *
    * The [testCache] argument provides a persistent store that can be used to
    * cache information about the test suite, so that directories do not need
    * to be listed each time.
    */
   void forEachTest(TestCaseEvent onTest, Map testCache, [VoidFunction onDone]);
 }
@@ skipping 765 matching lines @@
         return 'text/javascript';
       default:
         Expect.fail('Non-web runtime, so no scriptType for: '
                     '${configuration["compiler"]}');
         return null;
     }
   }
 
   bool get hasRuntime {
     switch(configuration['runtime']) {
-      case null:
-        Expect.fail("configuration['runtime'] is not set");

[ricow1, 2012/10/03 10:39:03]

if we don't pass runtime in on the command line don't we hit this?

[Mads Ager (google), 2012/10/03 10:44:10]

At this point I'm just cleaning this up. 'runtime' is always set. The option has
a default value 'vm' which you can overwrite, so this method is a no-op. I was
just doing this in passing, but this hasRuntime check should go away.

       case 'none':
         return false;
       default:
         return true;
     }
   }
 
   String getHtmlName(String filename) {
     var cleanFilename =  filename.replaceAll('/', '_')
                                  .replaceAll(':', '_')
@@ skipping 481 matching lines @@
         var prefix = '';
         if (configuration['use_sdk']) {
           prefix = 'dart-sdk/bin/';
         }
         if (configuration['host_checked']) {
           // The script dart2js_developer is not in the SDK.
           return 'dart2js_developer$suffix';
         } else {
           return '${prefix}dart2js$suffix';
         }
+        break;
       default:
         throw "Unknown executable for: ${configuration['compiler']}";
     }
   }
 
   static String compilerName(Map configuration) {
     String suffix = executableSuffix(configuration['compiler']);
     switch (configuration['compiler']) {
       case 'dartc':
       case 'dart2js':
@@ skipping 144 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }