Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5356)

Unified Diff: content/browser/gpu/gpu_blacklist.h

Issue 11047011: Figure out whether we have enough information to make the final GPU blacklisting decision. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/gpu/gpu_blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_blacklist.h
===================================================================
--- content/browser/gpu/gpu_blacklist.h (revision 160744)
+++ content/browser/gpu/gpu_blacklist.h (working copy)
@@ -92,6 +92,11 @@
// Returns the version of the current blacklist.
std::string GetVersion() const;
+ // Check if we needs more gpu info to make the blacklisting decisions.
+ // This is computed from the last MakeBlacklistDecision() call.
+ // If yes, we should create a gl context and do a full gpu info collection.
+ bool needs_more_info() const { return needs_more_info_; }
+
private:
friend class GpuBlacklistTest;
FRIEND_TEST_ALL_PREFIXES(GpuBlacklistTest, ChromeVersionEntry);
@@ -275,6 +280,10 @@
const Version& machine_model_version,
const content::GPUInfo& gpu_info) const;
+ // Determines whether we needs more gpu info to make the blacklisting
+ // decision. It should only be checked if Contains() returns true.
+ bool NeedsMoreInfo(const content::GPUInfo& gpu_info) const;
+
// Returns the OsType.
OsType GetOsType() const;
@@ -466,6 +475,8 @@
bool contains_unknown_fields_;
+ bool needs_more_info_;
+
std::string current_machine_model_name_;
scoped_ptr<Version> current_machine_model_version_;
« no previous file with comments | « no previous file | content/browser/gpu/gpu_blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698