Issue 11047008: CSSStyleDeclaration.getPropertyValue returns empty string instead of null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11047008: CSSStyleDeclaration.getPropertyValue returns empty string instead of null. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
vsm, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

CSSStyleDeclaration.getPropertyValue returns empty string instead of null. Committed: https://code.google.com/p/dart/source/detail?r=13189

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -4 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		3 chunks	+92 lines, -4 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/html/cssstyledeclaration_test.dart	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

The corresponding change for Dartium is being tracked here: http://code.google.com/p/dart/issues/detail?id=5617

8 years, 2 months ago (2012-10-03 00:41:31 UTC) #1

blois

https://codereview.chromium.org/11047008/diff/3001/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11047008/diff/3001/lib/html/dart2js/html_dart2js.dart#newcode4345 lib/html/dart2js/html_dart2js.dart:4345: + if (JS('bool', '!#.getPropertyValue(#)', this, propertyName)) { This is ...

8 years, 2 months ago (2012-10-03 00:56:47 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 11047008: CSSStyleDeclaration.getPropertyValue returns empty string instead of null. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Messages