Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1104693003: Use of base::StringPairs appropriately in base (Closed)

Created:
5 years, 8 months ago by packland
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in base Because base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/484fbc456f3e1194708a07a315332ef0454b280a Cr-Commit-Position: refs/heads/master@{#327129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M base/sys_info_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
packland
Please have a look at my fix, thank you.
5 years, 8 months ago (2015-04-25 21:37:06 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-27 20:11:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104693003/1
5 years, 8 months ago (2015-04-27 20:11:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 21:29:52 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:30:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/484fbc456f3e1194708a07a315332ef0454b280a
Cr-Commit-Position: refs/heads/master@{#327129}

Powered by Google App Engine
This is Rietveld 408576698