Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1104673004: [turbofan] Fix frame state for class literal definition. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix frame state for class literal definition. This introduces a bailout point for class literals right after the %DefineClass function has been called. Otherwise the FrameState after class literal evaluation might contain the literal itself. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-480819 BUG=chromium:480819 LOG=N Committed: https://crrev.com/6b60f191687d645f44c9050d29bd6573c3c9ef8c Cr-Commit-Position: refs/heads/master@{#28043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/ast.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-480819.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-24 09:35:40 UTC) #1
Jarin
lgtm
5 years, 8 months ago (2015-04-24 09:52:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104673004/1
5 years, 8 months ago (2015-04-24 11:12:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 11:13:19 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 11:13:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b60f191687d645f44c9050d29bd6573c3c9ef8c
Cr-Commit-Position: refs/heads/master@{#28043}

Powered by Google App Engine
This is Rietveld 408576698