Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1104643003: Supervised users: Post blocking pool tasks with CONTINUE_SHUTDOWN behavior. (Closed)

Created:
5 years, 8 months ago by Bernhard Bauer
Modified:
5 years, 8 months ago
CC:
chromium-reviews, pam+watch_chromium.org, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, gab
Base URL:
https://chromium.googlesource.com/chromium/src@issue388560
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supervised users: Post blocking pool tasks with CONTINUE_SHUTDOWN behavior. All call sites can deal with the blocking pool tasks continuing during shutdown, which means we don't have to block shutdown for them. BUG=481491 Committed: https://crrev.com/42bb56a59a89c56263310be7251aca3b6352d8ac Cr-Commit-Position: refs/heads/master@{#327025}

Patch Set 1 #

Messages

Total messages: 13 (3 generated)
Bernhard Bauer
Please review. Marc: FYI
5 years, 8 months ago (2015-04-23 16:24:35 UTC) #2
Marc Treib
Nice! Looks like we might want a helper method in BrowserThread for BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN).get() though?
5 years, 8 months ago (2015-04-23 17:45:51 UTC) #3
Bernhard Bauer
Since Gab is OOO, could you LGTM it, Marc? Also, adding Nikita for Chrome OS ...
5 years, 8 months ago (2015-04-24 15:41:22 UTC) #5
Marc Treib
On 2015/04/24 15:41:22, Bernhard Bauer wrote: > Since Gab is OOO, could you LGTM it, ...
5 years, 8 months ago (2015-04-24 17:16:30 UTC) #6
Nikita (slow)
I suggest referencing a bug (create one if needed)
5 years, 8 months ago (2015-04-24 18:57:50 UTC) #7
Nikita (slow)
lgtm
5 years, 8 months ago (2015-04-24 18:58:56 UTC) #8
Bernhard Bauer
On 2015/04/24 18:57:50, Nikita Kostylev wrote: > I suggest referencing a bug (create one if ...
5 years, 8 months ago (2015-04-27 10:06:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104643003/1
5 years, 8 months ago (2015-04-27 10:06:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 11:02:49 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 11:03:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42bb56a59a89c56263310be7251aca3b6352d8ac
Cr-Commit-Position: refs/heads/master@{#327025}

Powered by Google App Engine
This is Rietveld 408576698