Issue 110463003: Create extensions_test_support build target

Issue 110463003: Create extensions_test_support build target (Closed)

Created:
6 years, 12 months ago by James Cook

Modified:
6 years, 11 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Create extensions_test_support build target * Create extensions/common/test_util.h for shared test code * Consolidate duplicated CreateExtensionWithID() functions * Create extensions_test_support build target because you can't have multiple files named test_util.h in a single build target on MSVS, all the other names are taken (test_utils.h, extension_test_util.h, etc.), and this gets us a step closer to having an extensions-only test suite. * Fix some missing dependencies for the extensions_common target * Remove unnecessary includes that create a dependency on themes BUG=none TEST=compiles, unit_tests TBR=thakis@chromium.org for mechanical changes to chrome/browser/ui/cocoa/extensions/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243382

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -85 lines)			Patch
M	chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_test_util.h	View		1 chunk	+2 lines, -15 lines	0 comments	Download
M	chrome/common/extensions/extension_test_util.cc	View		1 chunk	+0 lines, -35 lines	0 comments	Download
M	extensions/browser/extension_registry_unittest.cc	View		3 chunks	+7 lines, -19 lines	0 comments	Download
M	extensions/browser/test_management_policy.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/common/extension.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
A	extensions/common/test_util.h	View		1 chunk	+27 lines, -0 lines	0 comments	Download
A	extensions/common/test_util.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	extensions/extensions.gyp	View	1 2 3	2 chunks	+26 lines, -0 lines	0 comments	Download