Pick frame to navigate in the browser process.

content/browser/frame_host/navigation_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
@@ skipping 713 matching lines @@
   }
 
   NavigationEntryImpl* entry = NavigationEntryImpl::FromNavigationEntry(
       CreateNavigationEntry(
           params.url,
           params.referrer,
           params.transition_type,
           params.is_renderer_initiated,
           params.extra_headers,
           browser_context_));
+  if (!params.frame_name.empty()) {
+    // This is only used for navigating subframes in tests.
+    FrameTreeNode* named_frame =
+        delegate_->GetFrameTree()->FindByName(params.frame_name);
+    if (named_frame)
+      entry->set_frame_tree_node_id(named_frame->frame_tree_node_id());
+  }
   if (params.frame_tree_node_id != -1)
     entry->set_frame_tree_node_id(params.frame_tree_node_id);

[alexmos, 2015/04/23 23:32:54]

Could it ever be the case that params specify both frame_name and
frame_tree_node_id?  Probably not given that the frame_name is only used in
layout tests, but just wanted to double-check that frame_tree_node_id overriding
frame_name is desired.

[Charlie Reis, 2015/04/24 18:30:54]

It's theoretically possible to set both in a test, but it seems ok for the
frame_tree_node_id to take precedence if you specify it.  I'm not concerned for
the long term, since NavigationEntryImpl::set_frame_tree_node_id is going away
in the session history work and this will behave differently.

   entry->set_source_site_instance(
       static_cast<SiteInstanceImpl*>(params.source_site_instance.get()));
   if (params.redirect_chain.size() > 0)
     entry->SetRedirectChain(params.redirect_chain);
   // Don't allow an entry replacement if there is no entry to replace.
   // http://crbug.com/457149
   if (params.should_replace_current_entry && entries_.size() > 0)
     entry->set_should_replace_entry(true);
   entry->set_should_clear_history_list(params.should_clear_history_list);
   entry->SetIsOverridingUserAgent(override);
   entry->set_transferred_global_request_id(
       params.transferred_global_request_id);
-  entry->SetFrameToNavigate(params.frame_name);
 
 #if defined(OS_ANDROID)
   if (params.intent_received_timestamp > 0) {
     entry->set_intent_received_timestamp(
         base::TimeTicks() +
         base::TimeDelta::FromMilliseconds(params.intent_received_timestamp));
   }
 #endif
 
   switch (params.load_type) {
@@ skipping 1095 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content