Issue 11046011: fix processing of non-switch arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11046011: fix processing of non-switch arguments (Closed)

Created:
8 years, 2 months ago by Sam Clegg

Modified:
8 years, 2 months ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

fix processing of non-switch arguments Without this fix AdditionalArguments were showing with with a '-' at the beginning. BUG=153682 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1426

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs	View		3 chunks	+19 lines, -12 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

binji

8 years, 2 months ago (2012-10-02 23:43:47 UTC) #2

lgtm

http://codereview.chromium.org/11046011/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs
(right):

http://codereview.chromium.org/11046011/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs:90: string
switchName = m_parsedBuildRule.SwitchPrefix + property.Switch +
property.Separator;
nit: wrap at 100

http://codereview.chromium.org/11046011/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs:102: // for
non-switchs such as AdditionalOpions we just append the value
nit:
s/switchs/switches/
s/Opions/Options/

Expand Messages | Collapse Messages