Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder_helper.cc

Issue 11046002: Browser Plugin: Fixed browser process crash on embedder reload. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Alternative behavior to match Istiaque's previous implementation of NavigateGuest Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder_helper.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder_helper.cc b/content/browser/browser_plugin/browser_plugin_embedder_helper.cc
index 7039b2bb06fa548466dab0491ea084c5bc8387f4..b8d68d25e0515b93fcf816e56557f7c19943a201 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder_helper.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder_helper.cc
@@ -33,6 +33,8 @@ bool BrowserPluginEmbedderHelper::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(BrowserPluginEmbedderHelper, message)
+ IPC_MESSAGE_HANDLER(BrowserPluginHostMsg_CreateGuest,
+ OnCreateGuest);
IPC_MESSAGE_HANDLER(BrowserPluginHostMsg_NavigateGuest,
OnNavigateGuest);
IPC_MESSAGE_HANDLER(BrowserPluginHostMsg_ResizeGuest, OnResizeGuest)
@@ -97,6 +99,16 @@ void BrowserPluginEmbedderHelper::OnHandleInputEvent(
reply_message);
}
+void BrowserPluginEmbedderHelper::OnCreateGuest(
+ int instance_id,
+ const std::string& storage_partition_id,
+ bool persist_storage) {
+ embedder_->CreateGuest(render_view_host(),
+ instance_id,
+ storage_partition_id,
+ persist_storage);
+}
+
void BrowserPluginEmbedderHelper::OnNavigateGuest(
int instance_id,
const std::string& src,

Powered by Google App Engine
This is Rietveld 408576698