Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1104573002: [Telemetry] Remove support for automatic record creation in smoothness controller. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
eakuefner, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove support for automatic record creation in smoothness controller. Add logic to make sure that page sets paired with smoothness/repaint only have interaction records with same label & they have repeatable flags enabled. To make sure that this doesn't crash any smoothness benchmarks, I modified benchmark_smoke_unittest to run all smoothness benchmarks (including ones that only support android) in patch #3. To validate the test runs, see telemetry_perf_unittest's result in patch #5 smoothness.key_silk_cases: https://codereview.chromium.org/1111543002/ smoothness.polymer: https://codereview.chromium.org/1060583012 BUG=444701, 444703 Committed: https://crrev.com/eb2eca9416822d172e0098e43790d41e7d33732c Cr-Commit-Position: refs/heads/master@{#327186}

Patch Set 1 #

Patch Set 2 : Tweak benchmark_smoke_test to run smoothness benchmarks #

Patch Set 3 : Enable all smoothness benchmark test for mobile #

Patch Set 4 : Update debugging message in smoothness_controller #

Patch Set 5 : Fix polymer page #

Patch Set 6 : Ready to land #

Total comments: 2

Patch Set 7 : Fix polymer page #

Patch Set 8 : Fix key_silk_cases & polymer #

Patch Set 9 : Enable benchmark_smoke_unittest to check before land #

Patch Set 10 : Fix key_silk_cases_2 #

Patch Set 11 : #

Patch Set 12 : Fix key_silk_cases for real #

Patch Set 13 : Undo changes to benchmark_smoke_unittest to land #

Patch Set 14 : Rebase to make sure CQ_EXTRA_TRYBOTS activated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -104 lines) Patch
M tools/perf/benchmarks/smoothness.py View 1 2 3 4 5 6 7 8 9 10 13 chunks +13 lines, -42 lines 0 comments Download
M tools/perf/measurements/repaint.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/perf/measurements/smoothness.py View 2 chunks +3 lines, -8 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +20 lines, -36 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +14 lines, -9 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
5 years, 8 months ago (2015-04-24 17:18:03 UTC) #4
eakuefner
lgtm https://codereview.chromium.org/1104573002/diff/140001/tools/perf/measurements/smoothness.py File tools/perf/measurements/smoothness.py (left): https://codereview.chromium.org/1104573002/diff/140001/tools/perf/measurements/smoothness.py#oldcode27 tools/perf/measurements/smoothness.py:27: def WillRunActions(self, page, tab): Just want to double-check ...
5 years, 8 months ago (2015-04-24 17:23:25 UTC) #5
nednguyen
https://codereview.chromium.org/1104573002/diff/140001/tools/perf/measurements/smoothness.py File tools/perf/measurements/smoothness.py (left): https://codereview.chromium.org/1104573002/diff/140001/tools/perf/measurements/smoothness.py#oldcode27 tools/perf/measurements/smoothness.py:27: def WillRunActions(self, page, tab): On 2015/04/24 17:23:25, eakuefner wrote: ...
5 years, 8 months ago (2015-04-24 17:25:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104573002/290001
5 years, 7 months ago (2015-04-27 22:07:08 UTC) #9
commit-bot: I haz the power
Committed patchset #14 (id:290001)
5 years, 7 months ago (2015-04-28 00:08:21 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 00:10:14 UTC) #11
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/eb2eca9416822d172e0098e43790d41e7d33732c
Cr-Commit-Position: refs/heads/master@{#327186}

Powered by Google App Engine
This is Rietveld 408576698