components/autofill/core/browser/credit_card.cc - Issue 1104543006: Style cleanups in Autofill for greater code clarity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card.cc

Issue 1104543006: Style cleanups in Autofill for greater code clarity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autocomplete_history_manager.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | components/autofill/core/browser/form_structure.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/credit_card.cc

diff --git a/components/autofill/core/browser/credit_card.cc b/components/autofill/core/browser/credit_card.cc

index 38b42941693d317d043b1e6ca07eb0a321b0bbdd..8bdab44d4ad63cff128d2808a239bbd14a55a271 100644

--- a/components/autofill/core/browser/credit_card.cc

+++ b/components/autofill/core/browser/credit_card.cc

@@ -408,7 +408,6 @@ void CreditCard::GetMatchingTypes(const base::string16& text,

if (!card_number.empty() && StripSeparators(text) == card_number)

matching_types->insert(CREDIT_CARD_NUMBER);

-NOTIMPLEMENTED() << " GETMATCINGTYPES " << text;

int month;

if (ConvertMonth(text, app_locale, &month) &&

month == expiration_month_) {